Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Fixed BOM value not updating on changing item #9350

Merged
merged 1 commit into from
Jun 19, 2017
Merged

[minor] Fixed BOM value not updating on changing item #9350

merged 1 commit into from
Jun 19, 2017

Conversation

sagarvora
Copy link
Collaborator

Reference: #8085

Made changes requested in #9305

Before

before 8085

After

after 8085

@rmehta
Copy link
Member

rmehta commented Jun 19, 2017

better UX is that it should select the default BOM instead of keeping it empty.

So when it is changed, pass a key changed and then if it is changed, either set the new default BOM or make it blank.

@rmehta rmehta closed this Jun 19, 2017
@sagarvora
Copy link
Collaborator Author

Hi, the get_bom_material_detail function on line 75 does select default BOM.

Proof:

proof

@sagarvora sagarvora reopened this Jun 19, 2017
@rmehta rmehta merged commit 086b6a3 into frappe:develop Jun 19, 2017
@barredterra barredterra mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagarvora @rmehta