Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard of customers, items, suppliers and sales partner #9354

Merged
merged 10 commits into from
Jun 20, 2017

Conversation

MCD-50
Copy link
Contributor

@MCD-50 MCD-50 commented Jun 19, 2017

Made a page under utilities modules.

Features:

return top 10 results based on doctype.
sort results based on the current filter selected
return results for a week, a month, a quarter and a year based on selected time.

GIF
ezgif com-crop

Screenshots
screenshot from 2017-06-19 13-36-41
screenshot from 2017-06-19 13-36-52

@mbauskar
Copy link
Contributor

@MCD-50,

Codacy and Travis build is failing, please fix the issues and reopen the PR

@mbauskar mbauskar closed this Jun 19, 2017
@rmehta rmehta reopened this Jun 19, 2017
@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Test Case Not Added / Updated

Since you have changed a Python file, you must update the relevant python test case. If there is no test coverage for this code, then please add it.

New DocType does have a test

Since you have created a new DocType, please add at least one test case.

Large Patch

This is a very large pull request, unless there is a very good reason, please try and break it down to smaller changes. Read this strategy on how it can be done

Documentation not updated

Since you have changed a DocType, check if this impacts any of the documentation related to it.

Demo not Updated

Since this is a large pull request, check if the demo is changed / updated


Result

  • Failed: User testing is mandatory for patches with changes in JS code.
  • Failed: Updating test cases is mandatory for large pull requests
  • Failed: User testing with animated GIF is mandatory for large pull requests.

This summary was automatically generated based on this script

@rmehta rmehta merged commit a111f78 into frappe:develop Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants