Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs management #9544

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Breadcrumbs management #9544

merged 1 commit into from
Jul 10, 2017

Conversation

britlog
Copy link
Contributor

@britlog britlog commented Jun 29, 2017

Improve breadcrumbs management.
Parents context contains all parents and parent_groups is not more used.

Please look corresponding PR in Frappe for animated gif (3588).

breadcrumbs-test

@mbauskar
Copy link
Contributor

@britlog,

Thanks for contributing!
Our contribution guidelines require that you add a screenshot showing that your proposed change works with an example. This pull request will be closed, but you can re-open it after adding the requested screenshot.
https://github.com/frappe/erpnext/wiki/Contribution-Guidelines

Also, please check the travis build log

@mbauskar mbauskar closed this Jun 30, 2017
@britlog
Copy link
Contributor Author

britlog commented Jun 30, 2017

@mbauskar

Hi, yes I know it that's why I wrote to go to the link PR 3588 in Frappe where I put the screenshot, I didn't want to duplicate it because this dev has 2 parts, one in Frappe and another in ERPNext.
Here is the direct link : frappe/frappe#3588

Thanks

@britlog
Copy link
Contributor Author

britlog commented Jun 30, 2017

I can't re-open the PR because it was not closed by myself, could you please do it ?

Thanks

@britlog
Copy link
Contributor Author

britlog commented Jul 7, 2017

@mbauskar @rmehta Could you please tell me why you don't want to re-open this PR ? I asked many time and don't know what to do or what you miss. Thanks

@rmehta rmehta reopened this Jul 7, 2017
@rmehta rmehta merged commit 8c85562 into frappe:develop Jul 10, 2017
@britlog britlog deleted the breadcrumbs2 branch September 23, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants