Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lead fixture, Added test for Lead, Opportunity #9607

Merged
merged 5 commits into from
Jul 11, 2017

Conversation

scmmishra
Copy link
Contributor

@scmmishra scmmishra commented Jul 4, 2017

For #9574

test_7_july

@scmmishra scmmishra force-pushed the test-shivam branch 2 times, most recently from 6008279 to c7f4dcd Compare July 4, 2017 10:29
@rmehta
Copy link
Member

rmehta commented Jul 6, 2017

rebase and push again so tests pass

@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Large Patch

This is a very large pull request, unless there is a very good reason, please try and break it down to smaller changes. Read this strategy on how it can be done

Please use modern JS API for forms

cur_frm is now deprecated and your patch contains code edited with cur_frm. Please re-write this code so that there are no references to cur_frm in your patch.


Result

  • Failed: User testing is mandatory for patches with changes in JS code.
  • Failed: Updating test cases is mandatory for large pull requests
  • Failed: User testing with animated GIF is mandatory for large pull requests.
  • Failed: cur_frm is used

This summary was automatically generated based on this script

@rmehta rmehta merged commit 3fe5ecc into frappe:develop Jul 11, 2017
@scmmishra scmmishra deleted the test-shivam branch July 8, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants