Merge pull request #17155 from frappe/mergify/bp/version-13-hotfix/pr…

…-17152 fix: JS error in page.js when the is a quote in button translation (backport #17152)
frappe · Jun 13, 2022 · 3b17f1e · 3b17f1e
2 parents a8ff365 + a4e07a0
commit 3b17f1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cypress/integration/custom_buttons.js b/cypress/integration/custom_buttons.js
@@ -4,6 +4,7 @@ const test_button_names = [
 	"Porcupine Tree (the GOAT)",
 	"AC / DC",
 	`Electronic Dance "music"`,
+	"l'imperatrice",
 ];
 
 const add_button = (label, group = "TestGroup") => {

diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js
@@ -505,7 +505,7 @@ frappe.ui.Page = Class.extend({
 
 		if (!label || !parent) return false;
 
-		const item_selector = `${selector}[data-label='${encodeURIComponent(label)}']`;
+		const item_selector = `${selector}[data-label="${encodeURIComponent(label)}"]`;
 
 		const existing_items = $(parent).find(item_selector);
 		if (existing_items && existing_items.length > 0) return existing_items;