fix: JS error in page.js when the is a quote in button translation #17152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #17152 +/- ##
===========================================
- Coverage 58.53% 54.92% -3.62%
===========================================
Files 777 766 -11
Lines 69429 68445 -984
Branches 6020 5854 -166
===========================================
- Hits 40641 37593 -3048
- Misses 25164 26734 +1570
- Partials 3624 4118 +494
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
approved these changes
Jun 12, 2022
surajshetty3416
added
the
ignore-flaky-test
surajshetty3416
added a commit
that referenced
this pull request
Jun 13, 2022
…-17152 fix: JS error in page.js when the is a quote in button translation (backport #17152)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a simple quote in translation on button there is an JS error
2022-06-12.12-13-24.mp4
I dig to this because in french translation file for ERPNext some simple quote are "HTML entitsed" with
'some not.I wonder why and as @marination on this ERPNext translation PR (frappe/erpnext#31232) ask me why I change some simple quote to
'. The fact is if there is a bug with simple quote I first want to change all simple quote to'to avoid all bugs, but this is a bad way to do it.I think it's better if we can avoid "HTML entitsed" into translation, write translation as we write in books is better.
So I found this in page.js and I propose the PR