fix(js): Handle hidden virtual fields (#24405) (#24691)

(cherry picked from commit 766a7ef) Co-authored-by: Corentin Flr <10946971+cogk@users.noreply.github.com>
frappe · Feb 2, 2024 · 50c18ab · 50c18ab
1 parent afd357b
commit 50c18ab
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/frappe/public/js/frappe/form/controls/base_control.js b/frappe/public/js/frappe/form/controls/base_control.js
@@ -47,9 +47,6 @@ frappe.ui.form.Control = class BaseControl {
 		if (this.df.get_status) {
 			return this.df.get_status(this);
 		}
-		if (this.df.is_virtual) {
-			return "Read";
-		}
 
 		if (
 			(!this.doctype && !this.docname) ||

diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js
@@ -194,7 +194,7 @@ $.extend(frappe.perm, {
 
 		if (!perm) {
 			let is_hidden = df && (cint(df.hidden) || cint(df.hidden_due_to_dependency));
-			let is_read_only = df && cint(df.read_only);
+			let is_read_only = df && (cint(df.read_only) || cint(df.is_virtual));
 			return is_hidden ? "None" : is_read_only ? "Read" : "Write";
 		}