refactor: make download button a primary action, update text

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
frappe · Mar 13, 2024 · 5f087ed · 5f087ed
1 parent 6a5af14
commit 5f087ed
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/frappe/public/js/frappe/list/bulk_operations.js b/frappe/public/js/frappe/list/bulk_operations.js
@@ -118,9 +118,15 @@ export default class BulkOperations {
 					let task_id = response.message.task_id;
 					frappe.realtime.task_subscribe(task_id);
 					frappe.realtime.on(`task_complete:${task_id}`, (data) => {
-						frappe.msgprint(
-							`Please click <a href=${data.file_url} target="_blank">here</a> to download the PDF`
-						);
+						frappe.msgprint({
+							title: __("Bulk PDF Export"),
+							message: __("Your PDF is ready for download"),
+							primary_action: {
+								label: __("Download PDF"),
+								client_action: "window.open",
+								args: data.file_url,
+							},
+						});
 						frappe.realtime.task_unsubscribe(task_id);
 						frappe.realtime.off(`task_complete:${task_id}`);
 					});