fix(UX): reload form after renaming field (backport #25159) (#25160)

* fix(UX): reload form after renaming field (#25159)

(cherry picked from commit af69dab)

# Conflicts:
#	frappe/custom/doctype/custom_field/custom_field.js

* chore: conflicts

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>

frappe/custom/doctype/custom_field/custom_field.js

@@ -112,28 +112,32 @@ frappe.ui.form.on("Custom Field", {
 		}
 	},
 	add_rename_field(frm) {
-		frm.add_custom_button(__("Rename Fieldname"), () => {
-			frappe.prompt(
-				{
-					fieldtype: "Data",
-					label: __("Fieldname"),
-					fieldname: "fieldname",
-					reqd: 1,
-					default: frm.doc.fieldname,
-				},
-				function (data) {
-					frappe.call({
-						method: "frappe.custom.doctype.custom_field.custom_field.rename_fieldname",
-						args: {
-							custom_field: frm.doc.name,
-							fieldname: data.fieldname,
-						},
-					});
-				},
-				__("Rename Fieldname"),
-				__("Rename")
-			);
-		});
+		if (!frm.is_new()) {
+			frm.add_custom_button(__("Rename Fieldname"), () => {
+				frappe.prompt(
+					{
+						fieldtype: "Data",
+						label: __("Fieldname"),
+						fieldname: "fieldname",
+						reqd: 1,
+						default: frm.doc.fieldname,
+					},
+					function (data) {
+						frappe
+							.xcall(
+								"frappe.custom.doctype.custom_field.custom_field.rename_fieldname",
+								{
+									custom_field: frm.doc.name,
+									fieldname: data.fieldname,
+								}
+							)
+							.then(() => frm.reload());
+					},
+					__("Rename Fieldname"),
+					__("Rename")
+				);
+			});
+		}
 	},
 });
 

frappe/custom/doctype/custom_field/custom_field.py

@@ -265,6 +265,7 @@ def rename_fieldname(custom_field: str, fieldname: str):
 	field.db_set("fieldname", field.fieldname, notify=True)
 	_update_fieldname_references(field, old_fieldname, new_fieldname)
 
+	frappe.msgprint(_("Custom field renamed to {0} successfully.").format(fieldname), alert=True)
 	frappe.db.commit()
 	frappe.clear_cache()