fix: raise exception if doc before save is not found (#18796) (#18820)

* fix: raise exception if doc before save is not found

* test: ensure error is raised when trying to save new doc using `doc.save()`

* chore: add comment explaining condition

* test: clearer name and docstring

(cherry picked from commit a42ca7d)

Co-authored-by: Sagar Vora <sagar@resilient.tech>

frappe/model/document.py

@@ -747,12 +747,13 @@ def check_if_latest(self):
 		Will also validate document transitions (Save > Submit > Cancel) calling
 		`self.check_docstatus_transition`."""
 
-		self.load_doc_before_save()
+		self.load_doc_before_save(raise_exception=True)
 
 		self._action = "save"
-		previous = self.get_doc_before_save()
+		previous = self._doc_before_save
 
-		if not previous or self.meta.get("is_virtual"):
+		# previous is None for new document insert
+		if not previous:
 			self.check_docstatus_transition(0)
 			return
 
@@ -1047,7 +1048,7 @@ def run_before_save_methods(self):
 
 		self.set_title_field()
 
-	def load_doc_before_save(self):
+	def load_doc_before_save(self, *, raise_exception: bool = False):
 		"""load existing document from db before saving"""
 
 		self._doc_before_save = None
@@ -1058,6 +1059,9 @@ def load_doc_before_save(self):
 		try:
 			self._doc_before_save = frappe.get_doc(self.doctype, self.name, for_update=True)
 		except frappe.DoesNotExistError:
+			if raise_exception:
+				raise
+
 			frappe.clear_last_message()
 
 	def run_post_save_methods(self):

frappe/tests/test_document.py

@@ -411,6 +411,19 @@ def test_realtime_notify(self):
 		todo.save()
 		self.assertEqual(todo.notify_update.call_count, 1)
 
+	def test_error_on_saving_new_doc_with_name(self):
+		"""Trying to save a new doc with name should raise DoesNotExistError"""
+
+		doc = frappe.get_doc(
+			{
+				"doctype": "ToDo",
+				"description": "this should raise frappe.DoesNotExistError",
+				"name": "lets-trick-doc-save",
+			}
+		)
+
+		self.assertRaises(frappe.DoesNotExistError, doc.save)
+
 
 class TestDocumentWebView(FrappeTestCase):
 	def get(self, path, user="Guest"):