fix: encode docname when routing (backport #17092) (#17374) (#18748)

(cherry picked from commit c8777c5)

Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
(cherry picked from commit eb4c4fb)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

cypress/integration/table_multiselect.js

@@ -54,6 +54,6 @@ context("Table MultiSelect", () => {
 			"existing_value"
 		);
 		cy.get("@existing_value").find(".btn-link-to-form").click();
-		cy.location("pathname").should("contain", "/user/test@erpnext.com");
+		cy.location("pathname").should("contain", "/user/test%40erpnext.com");
 	});
 });

frappe/public/js/frappe/list/list_view.js

@@ -938,11 +938,9 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 			return this.settings.get_form_link(doc);
 		}
 
-		const docname = cstr(doc.name).match(/[%'"#\s]/) ? encodeURIComponent(doc.name) : doc.name;
-
 		return `/app/${frappe.router.slug(
 			frappe.router.doctype_layout || this.doctype
-		)}/${docname}`;
+		)}/${encodeURIComponent(cstr(doc.name))}`;
 	}
 
 	get_seen_class(doc) {

frappe/public/js/frappe/router.js

@@ -430,12 +430,7 @@ frappe.router = {
 				frappe.route_options = a;
 				return null;
 			} else {
-				a = String(a);
-				if (a && a.match(/[%'"#\s\t]/)) {
-					// if special chars, then encode
-					a = encodeURIComponent(a);
-				}
-				return a;
+				return encodeURIComponent(String(a));
 			}
 		}).join("/");
 		let private_home = frappe.workspaces[`home-${frappe.user.name.toLowerCase()}`];