fix: raise exception if doc before save is not found (backport #18796) #18820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: raise exception if doc before save is not found * test: ensure error is raised when trying to save new doc using `doc.save()` * chore: add comment explaining condition * test: clearer name and docstring (cherry picked from commit a42ca7d)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
# [14.15.0](v14.14.3...v14.15.0) (2022-11-15) ### Bug Fixes * avoid patching QB if already patched ([a8ba877](a8ba877)) * breadcrumbs is broken ([90ca7b1](90ca7b1)) * check if the doctype exists before adding default logtypes in log settings ([#18867](#18867)) ([#18869](#18869)) ([93fe3e9](93fe3e9)) * dashboard view from workspace (backport [#18779](#18779)) ([#18813](#18813)) ([42f5e04](42f5e04)) * decorator ordering ([2245cc0](2245cc0)) * dont allow reading attributes of unsafe objects (backport [#18706](#18706)) ([#18806](#18806)) ([2b193bd](2b193bd)), closes [#18784](#18784) * hardcode doctype in google oauth callback ([#18862](#18862)) ([78a337b](78a337b)) * page has an empty menu button ([b2bbcde](b2bbcde)) * raise exception if doc before save is not found ([#18796](#18796)) ([#18820](#18820)) ([7505a0d](7505a0d)) * reportview permlevel bug ([#18822](#18822)) ([#18828](#18828)) ([ec248a9](ec248a9)) * **security:** prevent xss attack in search ([#18847](#18847)) ([#18850](#18850)) ([8807035](8807035)) ### Features * Set default SQL statement timeouts ([8ab95f4](8ab95f4)) * show utilization percent on RQ Worker ([#18868](#18868)) ([#18870](#18870)) ([a7060fa](a7060fa)) ### Performance Improvements * faster as_list and as_dict ([33d6369](33d6369)) * faster generate_hash (backport [#18825](#18825)) ([#18851](#18851)) ([bb5c7d5](bb5c7d5)) * **workflow:** get_transitions ([#18834](#18834)) ([#18839](#18839)) ([3f71181](3f71181)) ### Reverts * async await in breadcrumbs.js ([6a1e619](6a1e619))
|
🎉 This PR is included in version 14.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18796 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com