fix(link): list view filter with "show title in link field" (backport #25878) #25882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Steps to repro: - Setup show title in link field - on list view filter by that field - Use the URL and open the page again - filters will be erased This is happening because: - title->value map needs a db call to complete - in meantime if we ask for input value we get empty value (because input is empty) and then we end up returning `""` (cherry picked from commit fc78c06)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
# [14.71.0](v14.70.0...v14.71.0) (2024-04-09) ### Bug Fixes * add params in make_request arguments ([e16ebb7](e16ebb7)) * auto add modified index when sort_field is set to it (backport [#25686](#25686)) ([#25785](#25785)) ([0d57f1e](0d57f1e)) * bigint validation (backport [#25733](#25733)) ([#25821](#25821)) ([b2608b3](b2608b3)) * check if user exists in browse command ([a8c09d3](a8c09d3)) * cint -> avoid precision loss if already integer ([#25735](#25735)) ([#25736](#25736)) ([176cbd3](176cbd3)) * copy paste from Excel (issue [#24371](#24371)) ([30da5c5](30da5c5)) * copy paste from Excel (issue [#24371](#24371)) ([8d3d2e9](8d3d2e9)) * don't show bulk actions for doctype with workflow ([6703592](6703592)) * dont allow querying files to website users (backport [#25094](#25094)) ([#25700](#25700)) ([da5953c](da5953c)) * Get filter value based on depends_on field ([#25861](#25861)) ([#25863](#25863)) ([31b4453](31b4453)) * **grid:** don't crash if row doesn't exist ([db85d3c](db85d3c)) * **grid:** ensure that `doc.name` is truthy before proceeding ([#25800](#25800)) ([#25828](#25828)) ([71edfab](71edfab)) * Handle empty value of datetime control ([291ab66](291ab66)) * **layout:** handle `fieldobj` being null ([4c11499](4c11499)) * **link:** get_input_value returns `""` ([#25878](#25878)) ([#25882](#25882)) ([1e70ac8](1e70ac8)) * make_request - prevents an error during response parsing if the response body is empty. ([#24613](#24613)) ([d5c86a7](d5c86a7)) * max-width of email attachment filename ([d678571](d678571)) * only try JSON if content-type says so ([#24936](#24936)) ([e3c5ec4](e3c5ec4)) * respect custom filters on report export ([#25886](#25886)) ([f32b5d8](f32b5d8)) * type error in workflow ([#25847](#25847)) ([#25848](#25848)) ([835e43f](835e43f)) ### Features * add upstream json argument to integrations make_request ([#22462](#22462)) ([46a396e](46a396e)) * Include `before_print` in doctype event of Server Script (backport [#25858](#25858)) ([a36c68c](a36c68c)) ### Performance Improvements * **Scheduling:** add jitter to job scheduling ([#25856](#25856)) ([2a88f87](2a88f87)), closes [#19007](#19007)
|
🎉 This PR is included in version 14.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to repro:
This is happening because:
""This is an automatic backport of pull request #25878 done by [Mergify](https://mergify.com).