feat: Include before_print in doctype event of Server Script
#25858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sanket322
commented
Apr 8, 2024
Sanket322
commented
Sanket322
requested review from
a team and
ankush
and removed request for
a team
github-actions
bot
added
the
add-test-cases
sagarvora
added
backport version-15-hotfix
Sanket322
changed the title
before_print in doctype event of Server Scriptbefore_print in doctype event of Server Script
ankush
approved these changes
Apr 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit 9ee221b) # Conflicts: # frappe/core/doctype/server_script/server_script.json # frappe/core/doctype/server_script/server_script.py # frappe/core/doctype/server_script/server_script_utils.py
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit 9ee221b) # Conflicts: # frappe/core/doctype/server_script/server_script.json # frappe/core/doctype/server_script/server_script_utils.py
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
# [14.71.0](v14.70.0...v14.71.0) (2024-04-09) ### Bug Fixes * add params in make_request arguments ([e16ebb7](e16ebb7)) * auto add modified index when sort_field is set to it (backport [#25686](#25686)) ([#25785](#25785)) ([0d57f1e](0d57f1e)) * bigint validation (backport [#25733](#25733)) ([#25821](#25821)) ([b2608b3](b2608b3)) * check if user exists in browse command ([a8c09d3](a8c09d3)) * cint -> avoid precision loss if already integer ([#25735](#25735)) ([#25736](#25736)) ([176cbd3](176cbd3)) * copy paste from Excel (issue [#24371](#24371)) ([30da5c5](30da5c5)) * copy paste from Excel (issue [#24371](#24371)) ([8d3d2e9](8d3d2e9)) * don't show bulk actions for doctype with workflow ([6703592](6703592)) * dont allow querying files to website users (backport [#25094](#25094)) ([#25700](#25700)) ([da5953c](da5953c)) * Get filter value based on depends_on field ([#25861](#25861)) ([#25863](#25863)) ([31b4453](31b4453)) * **grid:** don't crash if row doesn't exist ([db85d3c](db85d3c)) * **grid:** ensure that `doc.name` is truthy before proceeding ([#25800](#25800)) ([#25828](#25828)) ([71edfab](71edfab)) * Handle empty value of datetime control ([291ab66](291ab66)) * **layout:** handle `fieldobj` being null ([4c11499](4c11499)) * **link:** get_input_value returns `""` ([#25878](#25878)) ([#25882](#25882)) ([1e70ac8](1e70ac8)) * make_request - prevents an error during response parsing if the response body is empty. ([#24613](#24613)) ([d5c86a7](d5c86a7)) * max-width of email attachment filename ([d678571](d678571)) * only try JSON if content-type says so ([#24936](#24936)) ([e3c5ec4](e3c5ec4)) * respect custom filters on report export ([#25886](#25886)) ([f32b5d8](f32b5d8)) * type error in workflow ([#25847](#25847)) ([#25848](#25848)) ([835e43f](835e43f)) ### Features * add upstream json argument to integrations make_request ([#22462](#22462)) ([46a396e](46a396e)) * Include `before_print` in doctype event of Server Script (backport [#25858](#25858)) ([a36c68c](a36c68c)) ### Performance Improvements * **Scheduling:** add jitter to job scheduling ([#25856](#25856)) ([2a88f87](2a88f87)), closes [#19007](#19007)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
# [15.21.0](v15.20.0...v15.21.0) (2024-04-09) ### Bug Fixes * add in_install flag to print_format validate (backport [#25752](#25752)) ([#25779](#25779)) ([b4eb918](b4eb918)) * auto add modified index when sort_field is set to it ([#25686](#25686)) ([#25786](#25786)) ([9e37908](9e37908)) * bigint validation (backport [#25733](#25733)) ([#25822](#25822)) ([4af75a1](4af75a1)) * check if user exists in browse command ([2b50e48](2b50e48)) * Column 'creation' in order clause was ambiguous ([97cc96e](97cc96e)) * copy paste from Excel (issue [#24371](#24371)) ([d816753](d816753)) * copy paste from Excel (issue [#24371](#24371)) ([a31c530](a31c530)) * **dashboard_chart:** use dict.get() to avoid a KeyError ([5fd854a](5fd854a)) * Don't assign returned values if row is deleted ([#25806](#25806)) ([#25826](#25826)) ([be3fd94](be3fd94)) * don't show bulk actions for doctype with workflow ([bf9ed2a](bf9ed2a)) * dont allow querying files to website users ([#25094](#25094)) ([#25701](#25701)) ([f95b4d6](f95b4d6)) * ensure we don't try to add int and NoneType ([8dcabaf](8dcabaf)) * Get filter value based on depends_on field ([#25861](#25861)) ([#25862](#25862)) ([dc113c4](dc113c4)) * **grid:** don't crash if row doesn't exist ([755d4a9](755d4a9)) * **grid:** ensure that `doc.name` is truthy before proceeding ([#25800](#25800)) ([#25829](#25829)) ([6234baf](6234baf)) * **layout:** handle `fieldobj` being null ([67eba0f](67eba0f)) * **link:** get_input_value returns `""` ([#25878](#25878)) ([#25883](#25883)) ([f918416](f918416)) * **ListView:** In ListView make visible link title value for Subject column ([#25569](#25569)) ([30737e5](30737e5)), closes [#25567](#25567) * log report errors to aid debugging ([#25738](#25738)) ([#25846](#25846)) ([ba8fd90](ba8fd90)) * make_request - prevents an error during response parsing if the response body is empty. ([#24613](#24613)) ([057db90](057db90)) * max-width of email attachment filename ([4b879f2](4b879f2)) * only try JSON if content-type says so ([#24936](#24936)) ([c5ddbb6](c5ddbb6)) * **sentry:** correctly skip `frappe.ValidationError` and its children ([e18ff5d](e18ff5d)) * type error in workflow ([#25847](#25847)) ([#25849](#25849)) ([32bbba3](32bbba3)) ### Features * don't require editing MariaDB configuration to setup frappe (backport [#25609](#25609)) ([#25757](#25757)) ([b47c658](b47c658)) * Include `before_print` in doctype event of Server Script (backport [#25858](#25858)) ([244be81](244be81)) * **router:** Go to default workspace when clicking app logo ([#25706](#25706)) ([#25727](#25727)) ([92919d1](92919d1)) ### Performance Improvements * render list (backport [#25524](#25524)) ([#25699](#25699)) ([d103b91](d103b91)) * **Scheduling:** add jitter to job scheduling ([#25857](#25857)) ([180c3b2](180c3b2)), closes [#19007](#19007)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.