feat: allow wildcard for doctype in permission hooks (backport #25729) #25891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: allow wildcard for doctype in permission hooks * fix: pass doctype to permission query * fix: combine methods instead of alternate * test: wildcard has_permssion hook * test: wildcard has_permssion make note public * fix: fetch list of hooks once (cherry picked from commit 7e16e90)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
# [14.72.0](v14.71.0...v14.72.0) (2024-04-16) ### Bug Fixes * handle empty style tag ([#25910](#25910)) ([#25915](#25915)) ([771fa80](771fa80)) * handle interface error during report timeout ([#25893](#25893)) ([#25894](#25894)) ([5d4e106](5d4e106)) * make letterhead attachments public by default (backport [#25925](#25925)) ([#25926](#25926)) ([6ea38b6](6ea38b6)) * make_error_msg for imap ([b2cfa49](b2cfa49)) ### Features * add option to set default email recipients ([#25555](#25555)) ([dc070a4](dc070a4)) * allow wildcard for doctype in permission hooks ([#25729](#25729)) ([#25891](#25891)) ([af33091](af33091)) * **Customize Form:** add "Trim Table" action (backport [#25923](#25923)) ([#25934](#25934)) ([ad34d52](ad34d52))
|
🎉 This PR is included in version 14.72.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for
permission_query_conditionsandhas_permissionhooks to accept"*"wildcard along with specific doctypes.Combining the list with
+=operator. so we get the doctype hook as well as wildcard hooks combined.docs: https://frappeframework.com/app/wiki-page-patch/f9a1b577f3
This is an automatic backport of pull request #25729 done by [Mergify](https://mergify.com).