Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Customize Form): add "Trim Table" action #25923

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Apr 11, 2024

no-docs

(will add after merge)

@barredterra barredterra requested review from a team and akhilnarang and removed request for a team April 11, 2024 17:08
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Apr 11, 2024
@barredterra barredterra removed the add-test-cases Add test case to validate fix or enhancement label Apr 11, 2024
@ankush ankush removed the request for review from akhilnarang April 11, 2024 17:11
@ankush ankush self-assigned this Apr 11, 2024
@ankush
Copy link
Member

ankush commented Apr 11, 2024

(will add dry run / confirmation before merge)

@ankush
Copy link
Member

ankush commented Apr 12, 2024

The message can get huge ig, but eh, better than nothing (?)

image

@ankush ankush enabled auto-merge April 12, 2024 05:27
@ankush ankush merged commit a16c571 into frappe:develop Apr 12, 2024
22 of 23 checks passed
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Apr 12, 2024
@barredterra barredterra deleted the trim-table-customize-form branch April 12, 2024 07:19
ankush added a commit that referenced this pull request Apr 12, 2024
* feat(Customize Form): add "Trim Table" action

(cherry picked from commit 9238f46)

* fix: Dry run and confirm before trimming tables

(cherry picked from commit a0268f1)

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush added the backport version-14-hotfix backport to version 14 label Apr 12, 2024
ankush added a commit that referenced this pull request Apr 12, 2024
* feat(Customize Form): add "Trim Table" action

(cherry picked from commit 9238f46)

# Conflicts:
#	frappe/custom/doctype/customize_form/customize_form.js
#	frappe/custom/doctype/customize_form/customize_form.py

* fix: Dry run and confirm before trimming tables

(cherry picked from commit a0268f1)

* chore: conflicts

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Apr 16, 2024
# [14.72.0](v14.71.0...v14.72.0) (2024-04-16)

### Bug Fixes

* handle empty style tag ([#25910](#25910)) ([#25915](#25915)) ([771fa80](771fa80))
* handle interface error during report timeout ([#25893](#25893)) ([#25894](#25894)) ([5d4e106](5d4e106))
* make letterhead attachments public by default (backport [#25925](#25925)) ([#25926](#25926)) ([6ea38b6](6ea38b6))
* make_error_msg for imap ([b2cfa49](b2cfa49))

### Features

* add option to set default email recipients ([#25555](#25555)) ([dc070a4](dc070a4))
* allow wildcard for doctype in permission hooks ([#25729](#25729)) ([#25891](#25891)) ([af33091](af33091))
* **Customize Form:** add "Trim Table" action (backport [#25923](#25923)) ([#25934](#25934)) ([ad34d52](ad34d52))
frappe-pr-bot pushed a commit that referenced this pull request Apr 16, 2024
# [15.23.0](v15.22.0...v15.23.0) (2024-04-16)

### Bug Fixes

* filter button translation ([#25944](#25944)) ([2bea73a](2bea73a))
* frm can be missing ([9e227b0](9e227b0))
* handle empty style tag ([#25910](#25910)) ([#25916](#25916)) ([34fbf6d](34fbf6d))
* handle interface error during report timeout ([#25893](#25893)) ([#25895](#25895)) ([6784b5d](6784b5d))
* let's color tag in form view ([#25949](#25949)) ([#25954](#25954)) ([0e6820d](0e6820d))
* limit title length on form ([#25880](#25880)) ([fb24480](fb24480))
* log out reliability ([#25865](#25865)) ([72b4540](72b4540))
* make letterhead attachments public by default ([#25925](#25925)) ([#25927](#25927)) ([c5c3424](c5c3424))
* private workspace routing (backport [#25904](#25904)) ([#25921](#25921)) ([c4eeb2e](c4eeb2e))
* reset announcements after saving settings ([b4ee409](b4ee409))
* show warning for pending migrations ([#25908](#25908)) ([#25909](#25909)) ([026514e](026514e)), closes [#25880](#25880)
* title width for form ([#25958](#25958)) ([#25959](#25959)) ([7a884e2](7a884e2))
* toolbar condition for setting up widget ([e42593e](e42593e))
* use boot to store announcement ([5f14e68](5f14e68))
* use localStorage for widget content ([642db78](642db78))

### Features

* add html for widget below navbar ([ea76002](ea76002))
* add option to filter email recipients ([c175911](c175911))
* add option to set default email recipients ([#25555](#25555)) ([bc496c1](bc496c1))
* allow wildcard for doctype in permission hooks ([#25729](#25729)) ([#25892](#25892)) ([7a4fa2f](7a4fa2f))
* announcement widget in navbar settings ([a947f44](a947f44))
* **APIv2:** Add comment via REST API ([#25889](#25889)) ([#25901](#25901)) ([2751be3](2751be3))
* **Customize Form:** add "Trim Table" action (backport [#25923](#25923)) ([#25933](#25933)) ([aa32595](aa32595))
* delete failed backups ([615cd71](615cd71))
* setup widget in toolbar ([e011cfa](e011cfa))

### Reverts

* Revert "test(UI): navbar announcements" ([3b23054](3b23054))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants