Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_doctypes_with_read: lists all doctypes, doesn't check read permission #26015

Closed
casesolved-co-uk opened this issue Apr 17, 2024 · 0 comments · Fixed by #26037
Closed

get_doctypes_with_read: lists all doctypes, doesn't check read permission #26015

casesolved-co-uk opened this issue Apr 17, 2024 · 0 comments · Fixed by #26037
Labels
bug

Comments

@casesolved-co-uk
Copy link
Contributor

There is no check for doctype read permission by this function

frappe/frappe/permissions.py

Line 454 in cab3b96

return list({cstr(p.parent) for p in get_valid_perms() if p.parent})

@casesolved-co-uk casesolved-co-uk mentioned this issue Apr 17, 2024
Closed
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue Apr 18, 2024
@casesolved-co-uk
fix: frappe#26017 and frappe#26015. Remove get_doctypes_with_custom_d…
b0ab586 
…ocperms because unused in frappe and erpnext
@ankush ankush mentioned this issue Apr 18, 2024
Merged
ankush added a commit to ankush/frappe that referenced this issue Apr 18, 2024
@ankush
fix: filter select perm in get_doctypes_with_read
f28dd28 
closes frappe#26015

Extracted from frappe#26018
ankush added a commit to ankush/frappe that referenced this issue Apr 18, 2024
@ankush
fix: filter select perm in get_doctypes_with_read
a1bb734 
closes frappe#26015

Extracted from frappe#26018
mergify bot pushed a commit that referenced this issue Apr 18, 2024
@ankush @mergify
fix: filter select perm in get_doctypes_with_read
5e2be4b 
closes #26015

Extracted from #26018

(cherry picked from commit a1bb734)

# Conflicts:
#	frappe/tests/test_permissions.py
@mergify mergify bot mentioned this issue Apr 18, 2024
Merged
mergify bot pushed a commit that referenced this issue Apr 18, 2024
@ankush @mergify
fix: filter select perm in get_doctypes_with_read
5bdd7ae 
closes #26015

Extracted from #26018

(cherry picked from commit a1bb734)
@mergify mergify bot mentioned this issue Apr 18, 2024
Merged
ankush added a commit that referenced this issue Apr 22, 2024
@mergify @ankush
fix: filter select perm in get_doctypes_with_read (backport #26037) (#…
2d7d38e 
…26040)

* fix: filter select perm in get_doctypes_with_read

closes #26015

Extracted from #26018

(cherry picked from commit a1bb734)

* ci: ruff only fix imports

(cherry picked from commit 229fc71)

# Conflicts:
#	.pre-commit-config.yaml

* test: add test for custom docperm behaviour

(cherry picked from commit 3f707f1)

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this issue Apr 30, 2024
@mergify @ankush
fix: filter select perm in get_doctypes_with_read (backport #26037) (#…
e889691 
…26039)

* fix: filter select perm in get_doctypes_with_read

closes #26015

Extracted from #26018

(cherry picked from commit a1bb734)

# Conflicts:
#	frappe/tests/test_permissions.py

* test: add test for custom docperm behaviour

(cherry picked from commit 3f707f1)

# Conflicts:
#	frappe/tests/test_permissions.py

* chore: conflicts

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filter select perm in get_doctypes_with_read ankush/frappe
1 participant
@casesolved-co-uk