perf: Cache get_tables values #10147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To avoid redundant db calls
surajshetty3416
requested review from
a team and
Thunderbottom
and removed request for
a team
surajshetty3416
force-pushed
the
fix-caching
branch
from
18b2368
to
e06e9c5
Compare
surajshetty3416
force-pushed
the
fix-caching
branch
from
e06e9c5
to
651109b
Compare
As indicated by deepsource
Thunderbottom
suggested changes
Apr 29, 2020
* use set comprehension instead of generator * remove redundant else statement Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference for the same query
Before
After
