Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data Import fixes #11083

Merged
merged 11 commits into from Aug 10, 2020
Merged

Conversation

netchampfaris
Copy link
Contributor

Validate select values in column

If a column whose fieldtype is Select has values that are not among the Options, then those will be shown in warnings.

image

Set default date format for parsed date values

When .xlsx files are parsed, date values become datetime objects. For these, the date format need not be guessed, so defaults to the standard date format yyyy-mm-dd HH:mm:ss.

Column warnings will now show the header title as well

image

Handle child table row additions

When a user wants to add rows to a table of an existing record, they must keep any existing rows with the ID column so that they are not overwritten and add the new rows keeping their ID column blank.

Show autoname field instead of ID

ID columns will be hidden for DocTypes with autoname set to field:fieldname, because showing fieldname is sufficient.

For e.g., Item Code is shown for Item and ID is hidden.
image

@netchampfaris
Copy link
Contributor Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@stale
Copy link

stale bot commented Aug 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 9, 2020
@surajshetty3416 surajshetty3416 added the resolve-conflicts There seems to be conflict due to changes in current branch. Please resolve it to get your PR merged label Aug 10, 2020
@surajshetty3416 surajshetty3416 removed inactive resolve-conflicts There seems to be conflict due to changes in current branch. Please resolve it to get your PR merged labels Aug 10, 2020
@prssanna prssanna merged commit 2317ffb into frappe:develop Aug 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2020

Command backport version-12-hotfix: success

Backports have been created

surajshetty3416 pushed a commit that referenced this pull request Aug 10, 2020
Co-authored-by: Faris Ansari <netchamp.faris@gmail.com>
hrwX pushed a commit to hrwX/frappe that referenced this pull request Oct 12, 2020
Co-authored-by: Faris Ansari <netchamp.faris@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants