-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhancement in notifications #11398
Conversation
@deepeshgarg007 should we add assigned users to the Receiver by Document Field options instead of using a new field to send to all Assignees? |
(df.options == 'User' && df.fieldtype == 'Link') | ||
? get_select_options(df, d.fieldname) : null; | ||
}); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this additional thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds fields with options as "User" and "Email" from child tables in the select dropdown in the recipients
table same way we do for fields on parent level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok can you add comments, because it is hard to read the logic.
also add comments in other places where you think it will be helpful in review ;-)
Technically it(Assignees) is not a doc field so thought to keep it outside as a separate field and not under the Receiver By Document field. Is there any docfield from where I can get all the assignees. If yes then let me know as I am not aware of it. We also have conditions at the parent level as well so there was no incentive to put it in the child table. Here a separate field makes it clear to the user what checking the field will do, in child table it might be a bit unclear. If moving the option in child table gives user more control and I have missed anything let me know, will move it to the child table then |
@deepeshgarg007 we have |
Ability to send notifications to assignees
Added a check to send emails to all assignees
Send notification based on child table field
Now child table fields also show up in the
receiver_by_document_field
in the recipients child table