Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total row in report print template #11459

Merged
merged 1 commit into from Sep 14, 2020

Conversation

prssanna
Copy link
Contributor

@prssanna prssanna commented Sep 8, 2020

Fixes:

  • Use data[0] only for Float and Currency fields in Total Row

  • Set Value as Total for 0th index column in Total Row

Before:
Screenshot 2020-09-08 at 8 58 40 PM

After:
Screenshot 2020-09-08 at 8 58 20 PM

@prssanna prssanna requested a review from a team as a code owner September 8, 2020 15:29
@prssanna prssanna requested review from surajshetty3416 and removed request for a team September 8, 2020 15:29
@mergify mergify bot merged commit 8d71bf4 into frappe:develop Sep 14, 2020
@prssanna
Copy link
Contributor Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Command backport version-12-hotfix: success

Backports have been created

surajshetty3416 pushed a commit that referenced this pull request Sep 16, 2020
(cherry picked from commit 662ccbb)

Co-authored-by: prssanna <prssud@gmail.com>
@prssanna
Copy link
Contributor Author

@Mergifyio backport v12-pre-release

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Command backport v12-pre-release: success

Backports have been created

surajshetty3416 pushed a commit that referenced this pull request Sep 16, 2020
(cherry picked from commit 662ccbb)

Co-authored-by: prssanna <prssud@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants