Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Email Account): Auto contact creation #11732

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

nextchamp-saqib
Copy link
Member

#10256 added a check to auto create contact only if Email Account has Create Contact checked.

This was supposed to stop auto creation of contacts, however it prevented adding timeline links if no email account was set in the communication document which breaks email aggregation

@stale
Copy link

stale bot commented Oct 31, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 31, 2020
@stale stale bot removed the inactive label Nov 2, 2020
@mergify mergify bot merged commit 34ec500 into frappe:develop Nov 2, 2020
@surajshetty3416 surajshetty3416 changed the title fix: email aggregation fix(Email Account): Auto contact creation Nov 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants