fix: Web Form not submitting data in grid views (bp #9851) #12292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Web forms work nicely with vanilla type fields. However, for child tables fields in grid views, the data is not submitted. The below instructions show how to replicate this issue: (cherry picked from commit 8fd9918)
(cherry picked from commit e7f0b42)
Codacy demands that we add this semi-colon https://app.codacy.com/gh/frappe/frappe/pullRequest?prid=5305922 . (cherry picked from commit fa6f052)
surajshetty3416
approved these changes
Feb 3, 2021
surajshetty3416
changed the title
Alchez
pushed a commit
to Alchez/frappe
that referenced
this pull request
Feb 22, 2021
…ppe#12292) Co-authored-by: Fumin <awawfumin@gmail.com> Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
This was referenced Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9851 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/