Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allowed the auto name in Customize Form #12413

Merged
merged 3 commits into from
Mar 23, 2021
Merged

feat: allowed the auto name in Customize Form #12413

merged 3 commits into from
Mar 23, 2021

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Feb 16, 2021 •
edited
Loading

Usecase- In some use case user need to define their own naming format. It's not possible since we are not allowing to override the standard autoname value (naming_series: -> field:).

Solution- Allowed the auto name in Customize Form so that user can define their own autoname format.

@anupamvs anupamvs requested review from a team and surajshetty3416 and removed request for a team February 16, 2021 09:55
@gavindsouza
Copy link
Collaborator

Is there any specific reason to not document this? I think adding a new field and functionality in Customize Form warrants user documentation at the very least.

@anupamvs anupamvs added the WIP Work In Progress, do not review label Mar 8, 2021
@anupamvs anupamvs force-pushed the naming branch 2 times, most recently from da93551 to 471232a Compare March 11, 2021 06:30
@anupamvs anupamvs removed the WIP Work In Progress, do not review label Mar 11, 2021
@surajshetty3416 surajshetty3416 added fix-sider-issues Check and fix issues listed by Sider add-docs New feature should be have an entry in documentation to increase the discoverability labels Mar 11, 2021
@anupamvs anupamvs removed the fix-sider-issues Check and fix issues listed by Sider label Mar 11, 2021
@anupamvs anupamvs requested a review from prssanna March 15, 2021 03:37
@prssanna prssanna added the fix-sider-issues Check and fix issues listed by Sider label Mar 17, 2021
@anupamvs anupamvs force-pushed the naming branch 2 times, most recently from b754139 to 5167619 Compare March 23, 2021 06:00
@prssanna
Copy link
Contributor

@anupamvs documentation still hasn't been linked

@anupamvs
Copy link
Contributor Author

@prssanna Documentation is not done yet.

@anupamvs anupamvs mentioned this pull request Mar 23, 2021
Merged
@anupamvs
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

Command backport version-13-pre-release: pending

Waiting for the pull request to get merged

@prssanna prssanna merged commit 509076d into frappe:develop Mar 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

Command backport version-13-pre-release: success

Backports have been created

@mergify mergify bot mentioned this pull request Mar 23, 2021
Merged
@saurabh6790
Copy link
Member

@Mergifyio backport version-13-beta-pre-release

@mergify mergify bot mentioned this pull request Mar 26, 2021
Closed
@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Command backport version-13-beta-pre-release: success

Backports have been created

@saurabh6790 saurabh6790 mentioned this pull request Mar 26, 2021
Merged
@barredterra
Copy link
Collaborator

barredterra commented Apr 21, 2021 •
edited
Loading

@anupamvs any update on the missing docs?

@chechani
Copy link

In Patient , it does not work as it still takes naming series as per option set in healthcare setting, pls look into

@lxnow
Copy link

lxnow commented Mar 18, 2022

format:EXAMPLE-{MM}morewords{fieldname1}-{fieldname2}-{#####} - Replace all braced words (fieldnames, date words (DD, MM, YY), series) with their value. Outside braces, any characters can be used.

How is the ##### portion (the numbers itself) get reset? It's not available in Naming Series doctype.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prssanna prssanna prssanna approved these changes

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees

@prssanna prssanna

@anupamvs anupamvs

Labels
add-docs New feature should be have an entry in documentation to increase the discoverability fix-sider-issues Check and fix issues listed by Sider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@anupamvs @gavindsouza @prssanna @saurabh6790 @barredterra @chechani @lxnow @nabinhait @surajshetty3416