fix: make app's server messages translatable #12479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szufisher
requested review from
a team and
surajshetty3416
and removed request for
a team
|
@netchampfaris Many thanks. Fisher |
|
Any further review findings? how to proceed? |
|
@szufisher Your change is breaking
|
seems the error you posted not generated from this PR's travis log, for me in my local development instance the same code runs just smoothly as expected. |
|
@szufisher Just tried it again. It breaks. Try running these commands step by step.
|
|
Closing due to inactivity. @szufisher Please re-open once the issue is fixed. |
|
Any updates? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error that attached file in comment with Chinese name does not work issue
refer to issue #12421