Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use IP Address instead of Email field #13553

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix: Use IP Address instead of Email field #13553

merged 2 commits into from
Aug 18, 2021

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Jun 23, 2021 •
edited
Loading

Removed Email field from Feedback.
Now using IP Address to keep track of the feedback of Guest User and added a limit of 20 feedback in 1 hour based on IP Address

Before:
image

After:
image

@stale stale bot added the inactive label Jul 6, 2021
@stale stale bot closed this Jul 9, 2021
@hasnain2808 hasnain2808 reopened this Jul 9, 2021
@stale stale bot removed the inactive label Jul 9, 2021
@shariquerik shariquerik removed the request for review from prssanna July 13, 2021 05:17
@frappe frappe deleted a comment from stale bot Jul 14, 2021
@stale stale bot added the inactive label Jul 21, 2021
@stale stale bot closed this Jul 24, 2021
@hasnain2808 hasnain2808 reopened this Jul 25, 2021
@stale stale bot removed the inactive label Jul 25, 2021
@surajshetty3416 surajshetty3416 added the tests-failing Automated tests are failing. Please resolve if it is due to the changes in current PR. label Jul 30, 2021
@shariquerik shariquerik requested a review from a team August 2, 2021 12:32
@shariquerik shariquerik removed the tests-failing Automated tests are failing. Please resolve if it is due to the changes in current PR. label Aug 2, 2021
@frappe frappe deleted a comment from stale bot Aug 2, 2021
@stale stale bot added the inactive label Aug 9, 2021
@frappe frappe deleted a comment from stale bot Aug 10, 2021
@stale stale bot removed the inactive label Aug 10, 2021
@stale stale bot added the inactive label Aug 17, 2021
@frappe frappe deleted a comment from stale bot Aug 17, 2021
@stale stale bot removed the inactive label Aug 17, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 46.55% when pulling deb537a on shariquerik:feedback-with-ip into 3e4aa8d on frappe:develop.

@surajshetty3416 surajshetty3416 merged commit 3baa33d into frappe:develop Aug 18, 2021
@shariquerik
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify mergify bot mentioned this pull request Aug 18, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2021

Command backport version-13-hotfix: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 18, 2021
@shariquerik
fix: Use IP Address instead of Email field (#13553)
4709a89 
(cherry picked from commit 3baa33d)
surajshetty3416 added a commit that referenced this pull request Aug 18, 2021
@surajshetty3416
Merge pull request #13967 from frappe/mergify/bp/version-13-hotfix/pr…
57831ff 
…-13553

fix: Use IP Address instead of Email field (backport #13553)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Sep 1, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasnain2808 hasnain2808 hasnain2808 approved these changes

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shariquerik @coveralls @hasnain2808 @surajshetty3416