fix: Webform Permission for custom doctype #13594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: frappe/erpnext#26232 |
Pull Request Test Coverage Report for Build 1185060577
💛 - Coveralls |
surajshetty3416
added
the
add-docs
shariquerik
removed
the
add-docs
surajshetty3416
requested changes
Aug 27, 2021
surajshetty3416
added
the
add-test-cases
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
shariquerik
removed
the
add-test-cases
|
@surajshetty3416 Added test case in erpnext PR frappe/erpnext#26232 |
|
@shariquerik since the code is in this repo it is better to have a unit test here. You can test out the response of |
surajshetty3416
approved these changes
Sep 6, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shariquerik
added a commit
that referenced
this pull request
Sep 20, 2021
|
Backport version-13-hotfix PR: #14267 |
ValentinaPruvost
pushed a commit
to fproldan/frappe
that referenced
this pull request
Dec 6, 2021
* fix: handle JSON content in run_doc_method * fix: publish realtime to work with localhost Currently, Publish realtime does not work in development environment untill and unless site get's opened with sitename. Fixed it by using currentsite.txt incase of host is localhost (by ignoring port). * fix: cannot read property 'datamanager' of undefined * refactor: child table filtering * refactor: child table filtering * fix: Show user name with workflow state in timeline (cherry picked from commit 602bfd4) * fix: Translate "You" in get_user_link * fix: allow updating naming series (Backport frappe#13204) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> * fix: Total Row in query report still hidden (backport frappe#14183) (frappe#14191) Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Duplicate name columns in list_view when no title field defined (backport frappe#14006) (frappe#14187) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> * fix: Show login page instantly (cherry picked from commit fd26415) * fix: Update login page & footer style (cherry picked from commit 7f7ab76) * fix: Redirect after login (cherry picked from commit 8b70727) * test: Add test case for redirection after login (cherry picked from commit 4c9fd57) * fix: Total Row hidden (frappe#14209) (cherry picked from commit 95ad6bb) * fix: Set DocumentNamingRule.counter as no_copy (cherry picked from commit 479a583) * chore: Drop extra license line (cherry picked from commit 79cd3ea) # Conflicts: # frappe/core/doctype/version/version.py * fix: Don't need postgres to use Frappe * Made code DRY-er by using obscure frappe.db.is_data_too_long * Python would run psycopg import line which would check if postgres is installed. Sites just wanting to chill w MariaDB would also need Postgres to be installed to get Frappe running. Fixes frappe#14193 (cherry picked from commit 1545ad6) * refactor: Use Query Builder instead of raw queries (cherry picked from commit 53f92e5) * fix: Invalid translation string (cherry picked from commit f1c29a1) # Conflicts: # frappe/utils/password.py * chore: Raise NotImplementedError in base Database class Methods that have to be overridden should throw NoteImplementedError. Helps during development :') (cherry picked from commit 713eaf6) * refactor: Query Builder over Raw SQL Converted 3 (1 multisql + 2 simple updates) raw queries in frappe.utils.password (cherry picked from commit fb42d9f) * fix: Merge conflicts from backport * fix(translation): Set translated text as html to get unescaped output (cherry picked from commit 268d344) * fix(UI): Clicking area around file view row opens the file (cherry picked from commit 90bc9e2) * fix: remove unnecessary padding (cherry picked from commit 1e22878) * fix: section with collapsible content jerk issue (cherry picked from commit ae10160) * fix(grid): date or datetime fields disappearing on save (frappe#14228) (cherry picked from commit fb50860) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix(UI): Checkbox hidden in List view in mobile view (frappe#14144) (cherry picked from commit 3bde63e) * fix(database): Fixed sql convention inconsistency (frappe#14230) (cherry picked from commit ac9ab3b) * fix: CSV upload failure (cherry picked from commit 9a66f18) * fix(grid): Delete all functionality (cherry picked from commit 47b0117) * fix: reverse tab navigation Reverse tab navigation seems to be broken from years, instead of going back to previous field it jumps to primary button. Root cause: when all fields are exhausted it's suppose to go to primary button, however that's not the case for shift-tab. (cherry picked from commit eafb8f6) * fix(Workflow Action): Pass doc to attach_print to avoid "Not Found" - Printview used to go empty for new document due to "Not Found" error in printview because that new document has not been saved in the database while processing workflow action email. (cherry picked from commit 20c9af5) * fix: Link workflow document (cherry picked from commit 1553ebd) * fix: update record linking desciption in Note (cherry picked from commit 1c693a8) * feat: Able to use custom port for database load balancers (cherry picked from commit 85834d7) * feat: custom database port for read-only replica configuration (cherry picked from commit 1ee2385) * fix: Keep checkbox checked after updating checked rows (backport frappe#14110) (frappe#14258) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Pass no_default_fields parameter further down to recursive calls (backport frappe#14158) (frappe#14200) (cherry picked from commit 4415351) Co-authored-by: Steffen <steffen@brennscheidt.net> * fix: properly queue tasks in `frappe.model.trigger` (frappe#14263) (cherry picked from commit 778ab59) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix: Webform Permission for custom doctype (frappe#13594) * refactor(minor): Built Assets Management (cherry picked from commit d802067) # Conflicts: # frappe/build.py * refactor: Show sync option only if mail protocol is imap * fix: Raise email account missing error if found while sending mail * fix: Sendmail is failing randomly This is happening because we enqueue the sendmail task before the current transaction is commited. enqueued task is looking for a document that is not yet commited and thus failing to send mails. * fix: change field type data to small text * fix: Only system manager is able to create tags Currently creating tags for a document by any user other than system manager throwing error. Fixed it by giving permissions to `ALL` role. (cherry picked from commit e4ef3a4) * fix: use decimal digits precision 9 instead of 6 while creating schema Currently we use DECIMAL(18, 6) datatype for float, currency and percent. But in the system settings we provide a configuration to change the precision up to 9 digits. This obviously does not work because we do not store 9 digit precision in database. Fixed by changing the decimal datatype scale. (cherry picked from commit a76445b) * fix: set correct title * fix(cleanup): cleanup email account, bug fix for web_template.js and more (cherry picked from commit cec53b5) * fix: Reloading doc before Setting Property After Alert (frappe#14048) * feat: provision to add multiple network printers (cherry picked from commit ec938c9) # Conflicts: # frappe/printing/doctype/print_settings/print_settings.json * fix: sider issues (cherry picked from commit 55bd04f) * fix: removing print statements (cherry picked from commit be2abdb) * review changes (cherry picked from commit cfe4dc4) # Conflicts: # frappe/printing/doctype/print_settings/print_settings.json * fix: sider issues (cherry picked from commit 2bd2ee3) * fix: error message (cherry picked from commit 3f0df69) * fix: error message (cherry picked from commit 0666796) * fix: sider issue (cherry picked from commit f10d225) * fix: conflict resolved * fix(Event Streaming): Doctype dependencies sync (frappe#14299) File "/home/mai/Workspace/V13/v13_online/apps/frappe/frappe/event_streaming/doctype/event_producer/event_producer.py", line 414, in sync_child_table_dependencies child_doc = frappe._dict(child_doc) TypeError: 'NoneType' object is not iterable (cherry picked from commit 1534e53) * fix: include doc details in workflow action email subject (cherry picked from commit 73843b0) * fix: number format converting to decimals (cherry picked from commit 39f504b) * fix: no need for focusout in favour of onchange (cherry picked from commit 52941e5) # Conflicts: # frappe/public/js/frappe/form/controls/int.js * test: tests for float control (cherry picked from commit 9eff8be) * chore: add semi colon (cherry picked from commit 8aea125) * test: tests for control: float (cherry picked from commit 9dc8f84) * revert: removal of flt on focus event (cherry picked from commit 21a4331) * fix: convert back to number_format on change (cherry picked from commit f29138d) # Conflicts: # frappe/public/js/frappe/form/controls/float.js * fix: make flt value idempotent (cherry picked from commit 4d0b0d3) * chore: sider (cherry picked from commit 906c70b) * minor: fix merge conflicts * minor: merge conflicts * fix: Get background jobs info (cherry picked from commit d333b00) * fix: syntax error in float.js * fix: Resolve conflicts * fix: Use capital M in max to avoid libsass compatibility issue sass/sass#2849 sass/sass#2849 (comment) (cherry picked from commit b389a90) * chore: change log for v13_12_0 * bumped to version 13.12.0 * fix: browser printing broken (cherry picked from commit 34ba19a) * bumped to version 13.12.1 * fix: translations * fix: remove changelog * feat: translations * feat: translations * fix: video translations * fix: remove duplicate parent when child item option * translations * fix: pagos360 * trans Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
fproldan
added a commit
to fproldan/frappe
that referenced
this pull request
Dec 6, 2021
* fix: handle JSON content in run_doc_method * fix: publish realtime to work with localhost Currently, Publish realtime does not work in development environment untill and unless site get's opened with sitename. Fixed it by using currentsite.txt incase of host is localhost (by ignoring port). * fix: cannot read property 'datamanager' of undefined * refactor: child table filtering * refactor: child table filtering * fix: Show user name with workflow state in timeline (cherry picked from commit 602bfd4) * fix: Translate "You" in get_user_link * fix: allow updating naming series (Backport frappe#13204) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> * fix: Total Row in query report still hidden (backport frappe#14183) (frappe#14191) Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Duplicate name columns in list_view when no title field defined (backport frappe#14006) (frappe#14187) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> * fix: Show login page instantly (cherry picked from commit fd26415) * fix: Update login page & footer style (cherry picked from commit 7f7ab76) * fix: Redirect after login (cherry picked from commit 8b70727) * test: Add test case for redirection after login (cherry picked from commit 4c9fd57) * fix: Total Row hidden (frappe#14209) (cherry picked from commit 95ad6bb) * fix: Set DocumentNamingRule.counter as no_copy (cherry picked from commit 479a583) * chore: Drop extra license line (cherry picked from commit 79cd3ea) * fix: Don't need postgres to use Frappe * Made code DRY-er by using obscure frappe.db.is_data_too_long * Python would run psycopg import line which would check if postgres is installed. Sites just wanting to chill w MariaDB would also need Postgres to be installed to get Frappe running. Fixes frappe#14193 (cherry picked from commit 1545ad6) * refactor: Use Query Builder instead of raw queries (cherry picked from commit 53f92e5) * fix: Invalid translation string (cherry picked from commit f1c29a1) * chore: Raise NotImplementedError in base Database class Methods that have to be overridden should throw NoteImplementedError. Helps during development :') (cherry picked from commit 713eaf6) * refactor: Query Builder over Raw SQL Converted 3 (1 multisql + 2 simple updates) raw queries in frappe.utils.password (cherry picked from commit fb42d9f) * fix: Merge conflicts from backport * fix(translation): Set translated text as html to get unescaped output (cherry picked from commit 268d344) * fix(UI): Clicking area around file view row opens the file (cherry picked from commit 90bc9e2) * fix: remove unnecessary padding (cherry picked from commit 1e22878) * fix: section with collapsible content jerk issue (cherry picked from commit ae10160) * fix(grid): date or datetime fields disappearing on save (frappe#14228) (cherry picked from commit fb50860) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix(UI): Checkbox hidden in List view in mobile view (frappe#14144) (cherry picked from commit 3bde63e) * fix(database): Fixed sql convention inconsistency (frappe#14230) (cherry picked from commit ac9ab3b) * fix: CSV upload failure (cherry picked from commit 9a66f18) * fix(grid): Delete all functionality (cherry picked from commit 47b0117) * fix: reverse tab navigation Reverse tab navigation seems to be broken from years, instead of going back to previous field it jumps to primary button. Root cause: when all fields are exhausted it's suppose to go to primary button, however that's not the case for shift-tab. (cherry picked from commit eafb8f6) * fix(Workflow Action): Pass doc to attach_print to avoid "Not Found" - Printview used to go empty for new document due to "Not Found" error in printview because that new document has not been saved in the database while processing workflow action email. (cherry picked from commit 20c9af5) * fix: Link workflow document (cherry picked from commit 1553ebd) * fix: update record linking desciption in Note (cherry picked from commit 1c693a8) * feat: Able to use custom port for database load balancers (cherry picked from commit 85834d7) * feat: custom database port for read-only replica configuration (cherry picked from commit 1ee2385) * fix: Keep checkbox checked after updating checked rows (backport frappe#14110) (frappe#14258) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Pass no_default_fields parameter further down to recursive calls (backport frappe#14158) (frappe#14200) (cherry picked from commit 4415351) Co-authored-by: Steffen <steffen@brennscheidt.net> * fix: properly queue tasks in `frappe.model.trigger` (frappe#14263) (cherry picked from commit 778ab59) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix: Webform Permission for custom doctype (frappe#13594) * refactor(minor): Built Assets Management (cherry picked from commit d802067) * refactor: Show sync option only if mail protocol is imap * fix: Raise email account missing error if found while sending mail * fix: Sendmail is failing randomly This is happening because we enqueue the sendmail task before the current transaction is commited. enqueued task is looking for a document that is not yet commited and thus failing to send mails. * fix: change field type data to small text * fix: Only system manager is able to create tags Currently creating tags for a document by any user other than system manager throwing error. Fixed it by giving permissions to `ALL` role. (cherry picked from commit e4ef3a4) * fix: use decimal digits precision 9 instead of 6 while creating schema Currently we use DECIMAL(18, 6) datatype for float, currency and percent. But in the system settings we provide a configuration to change the precision up to 9 digits. This obviously does not work because we do not store 9 digit precision in database. Fixed by changing the decimal datatype scale. (cherry picked from commit a76445b) * fix: set correct title * fix(cleanup): cleanup email account, bug fix for web_template.js and more (cherry picked from commit cec53b5) * fix: Reloading doc before Setting Property After Alert (frappe#14048) * feat: provision to add multiple network printers (cherry picked from commit ec938c9) * fix: sider issues (cherry picked from commit 55bd04f) * fix: removing print statements (cherry picked from commit be2abdb) * review changes (cherry picked from commit cfe4dc4) * fix: sider issues (cherry picked from commit 2bd2ee3) * fix: error message (cherry picked from commit 3f0df69) * fix: error message (cherry picked from commit 0666796) * fix: sider issue (cherry picked from commit f10d225) * fix: conflict resolved * fix(Event Streaming): Doctype dependencies sync (frappe#14299) File "/home/mai/Workspace/V13/v13_online/apps/frappe/frappe/event_streaming/doctype/event_producer/event_producer.py", line 414, in sync_child_table_dependencies child_doc = frappe._dict(child_doc) TypeError: 'NoneType' object is not iterable (cherry picked from commit 1534e53) * fix: include doc details in workflow action email subject (cherry picked from commit 73843b0) * fix: number format converting to decimals (cherry picked from commit 39f504b) * fix: no need for focusout in favour of onchange (cherry picked from commit 52941e5) * test: tests for float control (cherry picked from commit 9eff8be) * chore: add semi colon (cherry picked from commit 8aea125) * test: tests for control: float (cherry picked from commit 9dc8f84) * revert: removal of flt on focus event (cherry picked from commit 21a4331) * fix: convert back to number_format on change (cherry picked from commit f29138d) * fix: make flt value idempotent (cherry picked from commit 4d0b0d3) * chore: sider (cherry picked from commit 906c70b) * minor: fix merge conflicts * minor: merge conflicts * fix: Get background jobs info (cherry picked from commit d333b00) * fix: syntax error in float.js * fix: Resolve conflicts * fix: Use capital M in max to avoid libsass compatibility issue sass/sass#2849 sass/sass#2849 (comment) (cherry picked from commit b389a90) * chore: change log for v13_12_0 * bumped to version 13.12.0 * fix: browser printing broken (cherry picked from commit 34ba19a) * bumped to version 13.12.1 * fix: translations * fix: remove changelog * feat: translations * feat: translations * fix: video translations * fix: remove duplicate parent when child item option * translations * fix: pagos360 * trans Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
ValentinaPruvost
pushed a commit
to fproldan/frappe
that referenced
this pull request
Jan 18, 2022
* fix: handle JSON content in run_doc_method * fix: publish realtime to work with localhost Currently, Publish realtime does not work in development environment untill and unless site get's opened with sitename. Fixed it by using currentsite.txt incase of host is localhost (by ignoring port). * fix: cannot read property 'datamanager' of undefined * refactor: child table filtering * refactor: child table filtering * fix: Show user name with workflow state in timeline (cherry picked from commit 602bfd4) * fix: Translate "You" in get_user_link * fix: allow updating naming series (Backport frappe#13204) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> * fix: Total Row in query report still hidden (backport frappe#14183) (frappe#14191) Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Duplicate name columns in list_view when no title field defined (backport frappe#14006) (frappe#14187) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> * fix: Show login page instantly (cherry picked from commit fd26415) * fix: Update login page & footer style (cherry picked from commit 7f7ab76) * fix: Redirect after login (cherry picked from commit 8b70727) * test: Add test case for redirection after login (cherry picked from commit 4c9fd57) * fix: Total Row hidden (frappe#14209) (cherry picked from commit 95ad6bb) * fix: Set DocumentNamingRule.counter as no_copy (cherry picked from commit 479a583) * chore: Drop extra license line (cherry picked from commit 79cd3ea) * fix: Don't need postgres to use Frappe * Made code DRY-er by using obscure frappe.db.is_data_too_long * Python would run psycopg import line which would check if postgres is installed. Sites just wanting to chill w MariaDB would also need Postgres to be installed to get Frappe running. Fixes frappe#14193 (cherry picked from commit 1545ad6) * refactor: Use Query Builder instead of raw queries (cherry picked from commit 53f92e5) * fix: Invalid translation string (cherry picked from commit f1c29a1) * chore: Raise NotImplementedError in base Database class Methods that have to be overridden should throw NoteImplementedError. Helps during development :') (cherry picked from commit 713eaf6) * refactor: Query Builder over Raw SQL Converted 3 (1 multisql + 2 simple updates) raw queries in frappe.utils.password (cherry picked from commit fb42d9f) * fix: Merge conflicts from backport * fix(translation): Set translated text as html to get unescaped output (cherry picked from commit 268d344) * fix(UI): Clicking area around file view row opens the file (cherry picked from commit 90bc9e2) * fix: remove unnecessary padding (cherry picked from commit 1e22878) * fix: section with collapsible content jerk issue (cherry picked from commit ae10160) * fix(grid): date or datetime fields disappearing on save (frappe#14228) (cherry picked from commit fb50860) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix(UI): Checkbox hidden in List view in mobile view (frappe#14144) (cherry picked from commit 3bde63e) * fix(database): Fixed sql convention inconsistency (frappe#14230) (cherry picked from commit ac9ab3b) * fix: CSV upload failure (cherry picked from commit 9a66f18) * fix(grid): Delete all functionality (cherry picked from commit 47b0117) * fix: reverse tab navigation Reverse tab navigation seems to be broken from years, instead of going back to previous field it jumps to primary button. Root cause: when all fields are exhausted it's suppose to go to primary button, however that's not the case for shift-tab. (cherry picked from commit eafb8f6) * fix(Workflow Action): Pass doc to attach_print to avoid "Not Found" - Printview used to go empty for new document due to "Not Found" error in printview because that new document has not been saved in the database while processing workflow action email. (cherry picked from commit 20c9af5) * fix: Link workflow document (cherry picked from commit 1553ebd) * fix: update record linking desciption in Note (cherry picked from commit 1c693a8) * feat: Able to use custom port for database load balancers (cherry picked from commit 85834d7) * feat: custom database port for read-only replica configuration (cherry picked from commit 1ee2385) * fix: Keep checkbox checked after updating checked rows (backport frappe#14110) (frappe#14258) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Pass no_default_fields parameter further down to recursive calls (backport frappe#14158) (frappe#14200) (cherry picked from commit 4415351) Co-authored-by: Steffen <steffen@brennscheidt.net> * fix: properly queue tasks in `frappe.model.trigger` (frappe#14263) (cherry picked from commit 778ab59) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix: Webform Permission for custom doctype (frappe#13594) * refactor(minor): Built Assets Management (cherry picked from commit d802067) * refactor: Show sync option only if mail protocol is imap * fix: Raise email account missing error if found while sending mail * fix: Sendmail is failing randomly This is happening because we enqueue the sendmail task before the current transaction is commited. enqueued task is looking for a document that is not yet commited and thus failing to send mails. * fix: change field type data to small text * fix: Only system manager is able to create tags Currently creating tags for a document by any user other than system manager throwing error. Fixed it by giving permissions to `ALL` role. (cherry picked from commit e4ef3a4) * fix: use decimal digits precision 9 instead of 6 while creating schema Currently we use DECIMAL(18, 6) datatype for float, currency and percent. But in the system settings we provide a configuration to change the precision up to 9 digits. This obviously does not work because we do not store 9 digit precision in database. Fixed by changing the decimal datatype scale. (cherry picked from commit a76445b) * fix: set correct title * fix(cleanup): cleanup email account, bug fix for web_template.js and more (cherry picked from commit cec53b5) * fix: Reloading doc before Setting Property After Alert (frappe#14048) * feat: provision to add multiple network printers (cherry picked from commit ec938c9) * fix: sider issues (cherry picked from commit 55bd04f) * fix: removing print statements (cherry picked from commit be2abdb) * review changes (cherry picked from commit cfe4dc4) * fix: sider issues (cherry picked from commit 2bd2ee3) * fix: error message (cherry picked from commit 3f0df69) * fix: error message (cherry picked from commit 0666796) * fix: sider issue (cherry picked from commit f10d225) * fix: conflict resolved * fix(Event Streaming): Doctype dependencies sync (frappe#14299) File "/home/mai/Workspace/V13/v13_online/apps/frappe/frappe/event_streaming/doctype/event_producer/event_producer.py", line 414, in sync_child_table_dependencies child_doc = frappe._dict(child_doc) TypeError: 'NoneType' object is not iterable (cherry picked from commit 1534e53) * fix: include doc details in workflow action email subject (cherry picked from commit 73843b0) * fix: number format converting to decimals (cherry picked from commit 39f504b) * fix: no need for focusout in favour of onchange (cherry picked from commit 52941e5) * test: tests for float control (cherry picked from commit 9eff8be) * chore: add semi colon (cherry picked from commit 8aea125) * test: tests for control: float (cherry picked from commit 9dc8f84) * revert: removal of flt on focus event (cherry picked from commit 21a4331) * fix: convert back to number_format on change (cherry picked from commit f29138d) * fix: make flt value idempotent (cherry picked from commit 4d0b0d3) * chore: sider (cherry picked from commit 906c70b) * minor: fix merge conflicts * minor: merge conflicts * fix: Get background jobs info (cherry picked from commit d333b00) * fix: syntax error in float.js * fix: Resolve conflicts * fix: Use capital M in max to avoid libsass compatibility issue sass/sass#2849 sass/sass#2849 (comment) (cherry picked from commit b389a90) * chore: change log for v13_12_0 * bumped to version 13.12.0 * fix: browser printing broken (cherry picked from commit 34ba19a) * bumped to version 13.12.1 * fix: translations * fix: remove changelog * feat: translations * feat: translations * fix: video translations * fix: remove duplicate parent when child item option * translations * fix: pagos360 * trans Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
fproldan
added a commit
to fproldan/frappe
that referenced
this pull request
Jan 19, 2022
* fix: missing import (#9) (#11) Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> * feat: added more dates (#19) (#20) Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> * feat: user wise configure grid columns (#12) (#15) * feat: user wise configure grid columns (cherry picked from commit ddb0bef) * fix: code cleanup (cherry picked from commit 3c0d61f) * fix: conflict * fix: conflict * feat: translations * fix: translations * fix: translations * fix: translations Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> * feat: allow fuzzy search in website search (#14) (#16) * fix: conflicts and add asyncwritter * fix: conflicts and add asyncwritter * fix: conflicts and add asyncwritter * fix: trans Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> * fix: Leaderboard is not loading for user with language other than en (#13) (#18) * fix: Leaderboard is not loading for user with language other than en (cherry picked from commit 8f8f80f) * fix: translations Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> * Bumped to v13.12.1 (#17) (#22) * fix: handle JSON content in run_doc_method * fix: publish realtime to work with localhost Currently, Publish realtime does not work in development environment untill and unless site get's opened with sitename. Fixed it by using currentsite.txt incase of host is localhost (by ignoring port). * fix: cannot read property 'datamanager' of undefined * refactor: child table filtering * refactor: child table filtering * fix: Show user name with workflow state in timeline (cherry picked from commit 602bfd4) * fix: Translate "You" in get_user_link * fix: allow updating naming series (Backport frappe#13204) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> * fix: Total Row in query report still hidden (backport frappe#14183) (frappe#14191) Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Duplicate name columns in list_view when no title field defined (backport frappe#14006) (frappe#14187) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> * fix: Show login page instantly (cherry picked from commit fd26415) * fix: Update login page & footer style (cherry picked from commit 7f7ab76) * fix: Redirect after login (cherry picked from commit 8b70727) * test: Add test case for redirection after login (cherry picked from commit 4c9fd57) * fix: Total Row hidden (frappe#14209) (cherry picked from commit 95ad6bb) * fix: Set DocumentNamingRule.counter as no_copy (cherry picked from commit 479a583) * chore: Drop extra license line (cherry picked from commit 79cd3ea) * fix: Don't need postgres to use Frappe * Made code DRY-er by using obscure frappe.db.is_data_too_long * Python would run psycopg import line which would check if postgres is installed. Sites just wanting to chill w MariaDB would also need Postgres to be installed to get Frappe running. Fixes frappe#14193 (cherry picked from commit 1545ad6) * refactor: Use Query Builder instead of raw queries (cherry picked from commit 53f92e5) * fix: Invalid translation string (cherry picked from commit f1c29a1) * chore: Raise NotImplementedError in base Database class Methods that have to be overridden should throw NoteImplementedError. Helps during development :') (cherry picked from commit 713eaf6) * refactor: Query Builder over Raw SQL Converted 3 (1 multisql + 2 simple updates) raw queries in frappe.utils.password (cherry picked from commit fb42d9f) * fix: Merge conflicts from backport * fix(translation): Set translated text as html to get unescaped output (cherry picked from commit 268d344) * fix(UI): Clicking area around file view row opens the file (cherry picked from commit 90bc9e2) * fix: remove unnecessary padding (cherry picked from commit 1e22878) * fix: section with collapsible content jerk issue (cherry picked from commit ae10160) * fix(grid): date or datetime fields disappearing on save (frappe#14228) (cherry picked from commit fb50860) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix(UI): Checkbox hidden in List view in mobile view (frappe#14144) (cherry picked from commit 3bde63e) * fix(database): Fixed sql convention inconsistency (frappe#14230) (cherry picked from commit ac9ab3b) * fix: CSV upload failure (cherry picked from commit 9a66f18) * fix(grid): Delete all functionality (cherry picked from commit 47b0117) * fix: reverse tab navigation Reverse tab navigation seems to be broken from years, instead of going back to previous field it jumps to primary button. Root cause: when all fields are exhausted it's suppose to go to primary button, however that's not the case for shift-tab. (cherry picked from commit eafb8f6) * fix(Workflow Action): Pass doc to attach_print to avoid "Not Found" - Printview used to go empty for new document due to "Not Found" error in printview because that new document has not been saved in the database while processing workflow action email. (cherry picked from commit 20c9af5) * fix: Link workflow document (cherry picked from commit 1553ebd) * fix: update record linking desciption in Note (cherry picked from commit 1c693a8) * feat: Able to use custom port for database load balancers (cherry picked from commit 85834d7) * feat: custom database port for read-only replica configuration (cherry picked from commit 1ee2385) * fix: Keep checkbox checked after updating checked rows (backport frappe#14110) (frappe#14258) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> * fix: Pass no_default_fields parameter further down to recursive calls (backport frappe#14158) (frappe#14200) (cherry picked from commit 4415351) Co-authored-by: Steffen <steffen@brennscheidt.net> * fix: properly queue tasks in `frappe.model.trigger` (frappe#14263) (cherry picked from commit 778ab59) Co-authored-by: Sagar Vora <sagar@resilient.tech> * fix: Webform Permission for custom doctype (frappe#13594) * refactor(minor): Built Assets Management (cherry picked from commit d802067) * refactor: Show sync option only if mail protocol is imap * fix: Raise email account missing error if found while sending mail * fix: Sendmail is failing randomly This is happening because we enqueue the sendmail task before the current transaction is commited. enqueued task is looking for a document that is not yet commited and thus failing to send mails. * fix: change field type data to small text * fix: Only system manager is able to create tags Currently creating tags for a document by any user other than system manager throwing error. Fixed it by giving permissions to `ALL` role. (cherry picked from commit e4ef3a4) * fix: use decimal digits precision 9 instead of 6 while creating schema Currently we use DECIMAL(18, 6) datatype for float, currency and percent. But in the system settings we provide a configuration to change the precision up to 9 digits. This obviously does not work because we do not store 9 digit precision in database. Fixed by changing the decimal datatype scale. (cherry picked from commit a76445b) * fix: set correct title * fix(cleanup): cleanup email account, bug fix for web_template.js and more (cherry picked from commit cec53b5) * fix: Reloading doc before Setting Property After Alert (frappe#14048) * feat: provision to add multiple network printers (cherry picked from commit ec938c9) * fix: sider issues (cherry picked from commit 55bd04f) * fix: removing print statements (cherry picked from commit be2abdb) * review changes (cherry picked from commit cfe4dc4) * fix: sider issues (cherry picked from commit 2bd2ee3) * fix: error message (cherry picked from commit 3f0df69) * fix: error message (cherry picked from commit 0666796) * fix: sider issue (cherry picked from commit f10d225) * fix: conflict resolved * fix(Event Streaming): Doctype dependencies sync (frappe#14299) File "/home/mai/Workspace/V13/v13_online/apps/frappe/frappe/event_streaming/doctype/event_producer/event_producer.py", line 414, in sync_child_table_dependencies child_doc = frappe._dict(child_doc) TypeError: 'NoneType' object is not iterable (cherry picked from commit 1534e53) * fix: include doc details in workflow action email subject (cherry picked from commit 73843b0) * fix: number format converting to decimals (cherry picked from commit 39f504b) * fix: no need for focusout in favour of onchange (cherry picked from commit 52941e5) * test: tests for float control (cherry picked from commit 9eff8be) * chore: add semi colon (cherry picked from commit 8aea125) * test: tests for control: float (cherry picked from commit 9dc8f84) * revert: removal of flt on focus event (cherry picked from commit 21a4331) * fix: convert back to number_format on change (cherry picked from commit f29138d) * fix: make flt value idempotent (cherry picked from commit 4d0b0d3) * chore: sider (cherry picked from commit 906c70b) * minor: fix merge conflicts * minor: merge conflicts * fix: Get background jobs info (cherry picked from commit d333b00) * fix: syntax error in float.js * fix: Resolve conflicts * fix: Use capital M in max to avoid libsass compatibility issue sass/sass#2849 sass/sass#2849 (comment) (cherry picked from commit b389a90) * chore: change log for v13_12_0 * bumped to version 13.12.0 * fix: browser printing broken (cherry picked from commit 34ba19a) * bumped to version 13.12.1 * fix: translations * fix: remove changelog * feat: translations * feat: translations * fix: video translations * fix: remove duplicate parent when child item option * translations * fix: pagos360 * trans Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> * Modificaciones en los permisos de Activos (#24) (#27) * feat: translation * fix: patches Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> * fix: custom dialog box not working (#29) (#32) (cherry picked from commit f7a8ee7) Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> * feat: reset user-wise grid config to default (#31) (#33) * feat: reset user grid config to default (cherry picked from commit e0fadef) * trans: reset to default * fix: show "Button" field in user grid config Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Ankush Menat <ankush@frappe.io> * feat: Add an option to disable notification (#30) (#34) * feat: add option to disable notification * fix: reduce api call * fix * fix * feat: patch Co-authored-by: hrwx <himanshuwarekar@yahoo.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: hrwx <himanshuwarekar@yahoo.com> * Nueva forma de usar KPI (#25) (#35) * feat: dashboard * feat: dashboard * feat: dashboard * feat: dashboard * feat: filter by domain in dashboard chart * fix: trans * feat: workspace * feat: workspace * Sitio web fixed (#26) (#36) * feat: added web analytics to workspace * fix: workspace * fix: web form * feat: website * fix: patches * feat: improv setup * feat: improv setup * feat: improv setup * feat: fixtures * feat: fixtures * feat: fixtures * feat: fixtures * feat: domains * feat: rename web templates * feat: rename web templates * fix: typos * feat: hide Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> Co-authored-by: leela <leela.vadlamudi@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Gavin D'souza <gavin18d@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Co-authored-by: Steve <mcd.steven@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Jannat Patel <pateljannat2308@gmail.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Samuel Braun <42311986+MindLaborDev@users.noreply.github.com> Co-authored-by: Kenneth Sequeira <seq.kenneth@gmail.com> Co-authored-by: lukptr <lukptr@ridhosribumi.com> Co-authored-by: lukptr <17918335+lukptr@users.noreply.github.com> Co-authored-by: Steffen <steffen@brennscheidt.net> Co-authored-by: Leela vadlamudi <leela@users.noreply.github.com> Co-authored-by: bhavesh95863 <bhavesh.freelancer95863@gmail.com> Co-authored-by: Rushabh Mehta <rmehta@gmail.com> Co-authored-by: Anupam <anupamvns0099@gmail.com> Co-authored-by: Mai Ismail <mai.mq.1995@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: hrwx <himanshuwarekar@yahoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Supplier portal webforms for custom doctype are visible to all suppliers instead of specific to each supplier.
Example:
Custom Doctype
Order Assignmentis linked toPurchase Ordervia a Link field.A Webform
SO Scheduleis created which displays theOrder Assignment, but a supplier can see all theOrder Assignments, whereas he/she should only be able to seeOrder Assignmentfor which he/she has access to.Before:
After:
Docs: frappe/frappe_docs#173