New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Internal link support in custom document links #13823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
changed the title
fix: Internal link support for custom document links
fix: Internal link support for document links
Jul 31, 2021
@Mergifyio backport version-13-hotfix |
Command
|
deepeshgarg007
changed the title
fix: Internal link support for document links
fix: Internal link support in document links
Aug 3, 2021
deepeshgarg007
changed the title
fix: Internal link support in document links
fix: Internal link support in custom document links
Aug 3, 2021
surajshetty3416
changed the title
fix: Internal link support in custom document links
feat: Internal link support in custom document links
Aug 3, 2021
surajshetty3416
added
add-test-cases
Add test case to validate fix or enhancement
update-docs
labels
Aug 3, 2021
surajshetty3416
approved these changes
Aug 5, 2021
surajshetty3416
approved these changes
Aug 5, 2021
Command
|
AttributeError: 'DocType' object has no attribute 'get_field' Line 738 in doctype.py |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Internal links (doctype links in child table) cannot be added via Customize Form and only can be done in
{doctype}_dashboard.py
file.This PR allows the addition of internal links using Customize Form as well
docs: frappe/frappe_docs#176