Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Internal link support in custom document links #13823

Merged
merged 4 commits into from Aug 5, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jul 31, 2021

Currently, Internal links (doctype links in child table) cannot be added via Customize Form and only can be done in {doctype}_dashboard.py file.

This PR allows the addition of internal links using Customize Form as well

image

docs: frappe/frappe_docs#176

@deepeshgarg007 deepeshgarg007 changed the title fix: Internal link support for custom document links fix: Internal link support for document links Jul 31, 2021
@coveralls
Copy link

coveralls commented Jul 31, 2021

Coverage Status

Coverage decreased (-0.04%) to 46.544% when pulling 4c400bd on deepeshgarg007:custom_internal_links into e8c1a27 on frappe:develop.

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2021

Command backport version-13-hotfix: pending

Waiting for the pull request to get merged

@deepeshgarg007 deepeshgarg007 changed the title fix: Internal link support for document links fix: Internal link support in document links Aug 3, 2021
@deepeshgarg007 deepeshgarg007 changed the title fix: Internal link support in document links fix: Internal link support in custom document links Aug 3, 2021
@surajshetty3416 surajshetty3416 changed the title fix: Internal link support in custom document links feat: Internal link support in custom document links Aug 3, 2021
@surajshetty3416 surajshetty3416 added add-test-cases Add test case to validate fix or enhancement update-docs labels Aug 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2021

Command backport version-13-hotfix: success

Backports have been created

@JeansReal
Copy link
Contributor

AttributeError: 'DocType' object has no attribute 'get_field'

Line 738 in doctype.py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement update-docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants