fix: missing link in dashboard missing on SI from DN

[FHenry]

fix #27359

The field tabDelivery Note Item.against_sales_invoice is always empty on the process SO=>DN=>SI

[coveralls]

Coverage increased (+0.07%) to 51.504% when pulling aa7ee3c on FHenry:dev_fix_27359 into 14b0161 on frappe:develop.

[FHenry]

bug in version-12, version-13 and develop

Checking impact on other workflows

[FHenry]

What is the other workflow?
This is the only users use.

[nextchamp-saqib]

@FHenry Have you tried using the Document Links section for this?
Recently, frappe/frappe#13823 has provided a way to add internal links in the dashboard.

[FHenry]

@nextchamp-saqib

Have you tried using the Document Links section for this?
Recently, frappe/frappe#13823 has provided a way to add internal links in the dashboard.

Nice in develop branch, what about version-12 and version-13 ???? This is a bug in actual production version that must be fix

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[codecov]

Codecov Report

Merging #27360 (0bc213e) into develop (cc143bc) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27360      +/-   ##
===========================================
- Coverage    54.62%   54.50%   -0.13%     
===========================================
  Files         1334     1334              
  Lines        70756    70756              
===========================================
- Hits         38650    38564      -86     
- Misses       32106    32192      +86     

Impacted Files	Coverage Δ
...eport/item_variant_details/item_variant_details.py	32.14% <0.00%> (-55.96%)	⬇️
erpnext/utilities/product.py	15.94% <0.00%> (-34.79%)	⬇️
...wise_balance_history/batch_wise_balance_history.py	69.49% <0.00%> (-23.73%)	⬇️
erpnext/shopping_cart/product_info.py	32.35% <0.00%> (-20.59%)	⬇️
...e/shopping_cart_settings/shopping_cart_settings.py	66.03% <0.00%> (-1.89%)	⬇️
.../hr/doctype/upload_attendance/upload_attendance.py	45.11% <0.00%> (-1.51%)	⬇️
erpnext/shopping_cart/product_query.py	61.19% <0.00%> (-1.50%)	⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py	80.00% <0.00%> (-0.84%)	⬇️
erpnext/selling/doctype/sales_order/sales_order.py	76.48% <0.00%> (-0.75%)	⬇️
erpnext/portal/product_configurator/utils.py	33.06% <0.00%> (-0.41%)	⬇️
... and 7 more

[marination]

I think dashboard links in framework right now are problematic for child table linking. So this is the best way to go

[marination]

@Mergifyio backport version-13-hotfix

[mergify]

Command backport version-13-hotfix: success

Backports have been created

• #27830 fix: missing link in dashboard missing on SI from DN (backport #27360) has been created for branch version-13-hotfix

[marination]

@FHenry reverting this due to #23570 (this fix has been attempted before and breaks, reverting until theres a better solution)

[FHenry]

Ok, I understand, a better fix can be set against_sales_invoice when create SI from DN ?

[anandbaburajan]

@FHenry reverting this due to #23570 (this fix has been attempted before and breaks, reverting until theres a better solution)

@marination I've tried to fix it here: frappe/frappe#21722. It works AFAIK, but do you have any ideas on how it might break?

[marination]

@anandbaburajan I'm sorry I have forgotten any context I had with this issue since 2021 :(