Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor): Packages! also cleanup of DocField and other minor fixes #14123

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

rmehta
Copy link
Member

@rmehta rmehta commented Sep 5, 2021

Packages

Packages are light weight apps that can be exported and imported into different site. These exist only in the database and don't run an unrestricted code.

A Package is essentially a group of modules. You can download a Package by making a new Package Release. You can then download the package and import it to another site via Package Import

Package export and import is very similar to an app (uses the same routines)

Defining a Package

Screenshot 2021-09-05 at 10 06 25 PM

Package Release

Screenshot 2021-09-05 at 10 06 34 PM

Package Import

Screenshot 2021-09-05 at 9 53 29 PM

Extension to Module

  • Added Document Links - Packages will be defined by these links

Screenshot 2021-09-05 at 10 08 41 PM

Cleanup to DocField

Long time pending

Screenshot 2021-09-05 at 10 10 36 PM

Added "Naming Rule" in DocType

Screenshot 2021-09-05 at 10 11 03 PM

docs: frappe/frappe_docs#191

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #14123 (d807e3b) into develop (b2f78de) will increase coverage by 0.01%.
The diff coverage is 66.34%.

@@             Coverage Diff             @@
##           develop   #14123      +/-   ##
===========================================
+ Coverage    56.25%   56.26%   +0.01%     
===========================================
  Files          499      502       +3     
  Lines        41290    41456     +166     
===========================================
+ Hits         23226    23326     +100     
- Misses       18064    18130      +66     
Impacted Files Coverage Δ
...appe/core/doctype/package_import/package_import.py 0.00% <0.00%> (ø)
frappe/model/naming.py 71.94% <0.00%> (ø)
frappe/model/sync.py 0.00% <ø> (ø)
frappe/utils/safe_exec.py 90.21% <ø> (ø)
frappe/core/doctype/doctype/doctype.py 77.39% <37.50%> (-0.44%) ⬇️
frappe/modules/import_file.py 74.76% <64.28%> (-2.77%) ⬇️
frappe/core/doctype/file/file.py 87.29% <66.66%> (+0.02%) ⬆️
frappe/core/doctype/package/package.py 70.00% <70.00%> (ø)
...pe/core/doctype/package_release/package_release.py 93.61% <93.61%> (ø)
frappe/database/database.py 78.60% <94.11%> (+0.48%) ⬆️
... and 16 more

@rmehta rmehta merged commit ea27dd0 into frappe:develop Sep 6, 2021
@JeansReal
Copy link
Contributor

@rmehta Hi!

I have some time working with a custom frappe app: https://github.com/AgileShift/cargo_management/

I was updating Frappe and Erpnext to version-14-beta and I found a conflict with the Doctype "Package"
As for ourselves a "Package" is a parcel sent from a courrier.

My question what options did you think I have to rename the custom doctype name "Package" or this core functionality can be somewhat hidden?

New Frappe Core Doctype
Screenshot from 2022-02-16 14-35-53

Custom DocType
Screenshot from 2022-02-16 14-36-12

We have a couple of sites on production actually, I we want to be on the beta to get creative with the new Print Format builder

Screenshot from 2022-02-16 14-37-58

Hope you can give me a hint, best regards

@agritheory
Copy link
Contributor

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants