feat: New Print Format Builder

[netchampfaris]

Refactor of Print Format Builder has been long overdue. This PR tries to fix the culmination of all the frustrations I have had with the current PFB.

Features

• Better drag-n-drop implementation
• Inline section and field labels editing
• Intuitive table column editing
• Custom page margins
• Custom font
• Page breaks after sections
• Uses weasyprint as the PDF renderer

Why weasyprint?

wkhtmltopdf uses a really old version of WebKit which doesn't even support standard flexbox implementation. This is the primary reason why I decided to look for an alternative. wkhtmltopdf's status page basically says that there is no promise that it will be updated to the latest WebKit engine.

However, weasyprint does not only fix the flexbox problem, it implements standard W3C CSS specifications, which means there is a standard feature to add page numbers in a PDF rather than a JS hack. Not only this, there is whole bunch of standard CSS features that allow you to customize a PDF. This was an exciting discovery.

Demo

The new Print Format Builder works alongside the current one with a feature flag in the Print Format document. So it does not break existing formats and is opt-in for now.

Show GIF

Installation

weasyprint is a pure python package but it depends on a few libraries. Follow the installation instructions at weasyprint installation page

For macOS users, simple run:

brew install pango libffi

ToDo

• Fix print preview in form
• Letterhead editing
• Handle custom formats, for e.g., template for Sales Taxes and Charges

no-docs

[codecov]

Codecov Report

Merging #14134 (c1053be) into develop (ff27f80) will increase coverage by 0.56%.
The diff coverage is 20.87%.

@@             Coverage Diff             @@
##           develop   #14134      +/-   ##
===========================================
+ Coverage    49.72%   50.28%   +0.56%     
===========================================
  Files          744      747       +3     
  Lines        65023    65367     +344     
  Branches      5435     5460      +25     
===========================================
+ Hits         32332    32872     +540     
+ Misses       28720    28603     -117     
+ Partials      3971     3892      -79     

Flag	Coverage Δ
server	56.77% <19.66%> (-0.06%)	⬇️
ui-tests	38.34% <75.00%> (+1.72%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[surajshetty3416]

@netchampfaris What's the update on this? Is this ready for QA testing for basic/core functionalities?

[surajshetty3416]

@netchampfaris Nice enhancements overall 👍

Noticed a few things that can be fixed.

• 
  These icons are confusing because in form view it signifies "Print" and "Refresh"… most people will not try to click on these for “Preview” and “Reset". Suggestion: Add text to the button

• 
  Background color of controls are not the same

• 
  This!!

• 
  Changing these options should update the preview in real-time (at least for HTML preview). The preview feature shines while tweaking such variables. (We can skip this if this requires major changes or if there are performance concerns)

[surajshetty3416]

Fair enough but I think we should add barebones docs. Test cases could be deferred but, I have a feeling there should be some basic ones for the weasyprint APIs at this stage. Although, if you don't see the need for them, idm as long as they get added in the near future 😛

Let's skip the documentation for now (to avoid docs for namesake). I have created a backlog to ensure the documentation and tests are added by next month.

[surajshetty3416]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[surajshetty3416]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated