fix: for frappe._dict deepcopy; Opened issue 14833 #14889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developmentforpeople
requested review from
hasnain2808
and removed request for
a team
gavindsouza
requested changes
Nov 8, 2021
developmentforpeople
force-pushed
the
version-13-hotfix
branch
from
92cb811
to
000e3d2
Compare
…pted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com>
…pted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com>
|
Thanks for your help @gavindsouza ;) |
gavindsouza
approved these changes
Nov 8, 2021
|
@Mergifyio backport develop |
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
* fix: DFP "__deepcopy__" exception" within _dict __getattr__ * fix: for frappe._dict deepcopy; Opened issue 14833 #14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> * fix: for frappe._dict deepcopy; Opened issue 14833 #14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> Co-authored-by: gavin <gavin18d@gmail.com> (cherry picked from commit db6996a)
✅ Backports have been created
|
barredterra
pushed a commit
that referenced
this pull request
Nov 8, 2021
* fix: DFP "__deepcopy__" exception" within _dict __getattr__ * fix: for frappe._dict deepcopy; Opened issue 14833 #14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> * fix: for frappe._dict deepcopy; Opened issue 14833 #14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> Co-authored-by: gavin <gavin18d@gmail.com> (cherry picked from commit db6996a) Co-authored-by: Development for People <47140294+developmentforpeople@users.noreply.github.com>
conncampbell
pushed a commit
to conncampbell/frappe
that referenced
this pull request
Jan 9, 2022
…appe#14914) * fix: DFP "__deepcopy__" exception" within _dict __getattr__ * fix: for frappe._dict deepcopy; Opened issue 14833 frappe#14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> * fix: for frappe._dict deepcopy; Opened issue 14833 frappe#14889 (accepted gavindsouza suggestion) Co-authored-by: gavin <gavin18d@gmail.com> Co-authored-by: gavin <gavin18d@gmail.com> (cherry picked from commit db6996a) Co-authored-by: Development for People <47140294+developmentforpeople@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more to explain that explained in opened issue:
Frappe Issue #14833
Selected option b offered by @barredterra
closes #14833