Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make "Use original name for amended document" setting read-only #15278

Conversation

hasnain2808
Copy link
Contributor

This PR will not allow turning on "Use original name for amended document" setting in System Settings for sites that do not have turned it on yet.

image

This PR should be followed by another pr which will remove this functionality entirely with a patch to revert changes.

Making use_original_name_for_amended_document in system setting to be readonly. This is done to make sure others cannot turn on the setting
@surajshetty3416 surajshetty3416 changed the title revert: set amended docname to original docname-1 fix: Make "Use original name for amended document" setting read-only Dec 14, 2021
@mergify mergify bot merged commit 7bba5d7 into frappe:version-13-hotfix Dec 14, 2021
@surajshetty3416
Copy link
Member

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2021

backport version-13-pre-release

✅ Backports have been created

@dj12djdjs
Copy link
Member

I would love to have the changes by this check box reverted. Just to be clear by the follow up patch you mean all documents with -CANCEL-# should be reverted to DOC-# ?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants