fix: Clear fetched field when link field is cleared #15343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumaiya2908
requested review from
surajshetty3416
and removed request for
a team
surajshetty3416
changed the title
surajshetty3416
requested changes
Dec 17, 2021
There was a problem hiding this comment.
@sumaiya2908 the fix does not work with this change #15320
You might have to update the code
surajshetty3416
approved these changes
Dec 22, 2021
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
Codecov Report
@@ Coverage Diff @@
## develop #15343 +/- ##
===========================================
+ Coverage 49.78% 50.80% +1.01%
===========================================
Files 745 742 -3
Lines 65234 65320 +86
Branches 5419 5432 +13
===========================================
+ Hits 32479 33186 +707
+ Misses 28825 28272 -553
+ Partials 3930 3862 -68
Flags with carried forward coverage won't be shown. Click here to find out more. |
❌ No backport have been created
|
|
@sumaiya2908 A support ticket was raised for Frappe v14 (develop) even though we haven't started stable releases for it? |
|
@gavindsouza the issue was raised for v13. And when I checked, it existed in develop too. So I raised a PR for develop, and then backported it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the link field is cleared, the docfield which is fetched from the link field remains the same as the previous value and gets saved.
Before
the 'Name' field is read-only.
Screen.Recording.2021-12-17.at.9.17.18.AM.mov
After
Screen.Recording.2021-12-17.at.9.18.22.AM.mov
Steps to reproduce
a. Expected Result: the field which is being fetched, should be cleared.
b. Actual Result: it remains the same as the previous value and gets saved.