Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not validate if options is undefined (backport #15470) #15475

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 29, 2021

This is an automatic backport of pull request #15470 done by Mergify.
Cherry-pick of 0fd20c7 has failed:

On branch mergify/bp/version-13-hotfix/pr-15470
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit 0fd20c7862.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/public/js/frappe/form/controls/link.js

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0fd20c7)

# Conflicts:
#	frappe/public/js/frappe/form/controls/link.js
@mergify mergify bot requested a review from a team as a code owner December 29, 2021 06:19
@mergify mergify bot requested review from hasnain2808 and removed request for a team December 29, 2021 06:19
@mergify mergify bot added the conflicts label Dec 29, 2021
@surajshetty3416
Copy link
Member

@shariquerik, @sumaiya2908 you might have to backport this PR first before backporting this PR.

@mergify mergify bot deleted the mergify/bp/version-13-hotfix/pr-15470 branch December 31, 2021 16:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants