feat: option to not rebuild search on rename #15443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport version-13-hotfix |
🟠 Waiting for conditions to match
Hey, I reacted but my real name is @Mergifyio |
Codecov Report
@@ Coverage Diff @@
## develop #15443 +/- ##
===========================================
+ Coverage 47.01% 49.79% +2.78%
===========================================
Files 745 745
Lines 65258 65259 +1
Branches 5419 5419
===========================================
+ Hits 30678 32495 +1817
+ Misses 30650 28834 -1816
Partials 3930 3930
Flags with carried forward coverage won't be shown. Click here to find out more. |
hrwX
reviewed
Dec 24, 2021
gavindsouza
approved these changes
Dec 27, 2021
✅ Backports have been created
|
|
@Mergifyio backport version-12-hotfix This looks like a fix to me, so backporting it to v12 too 🎁 |
✅ Backports have been created
|
surajshetty3416
pushed a commit
that referenced
this pull request
Dec 27, 2021
surajshetty3416
added a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bulk rename, it doesn't make sense to rebuild search for each individual record. For example, if we rename 40 records, the search will be rebuilt 40 times.
Let's add an option to not rebuild search in
rename_doc, for methods likebulk_rename. They will explicitly rebuild search once all records have been renamed.