fix: Recursive routing for Form route

[pruthvi145]

Issue

In many places, to a make new document, we just do set_route to /new which eventually redirects to the actual form having local docname (e.g new-item-1). However, this leaves the history for /new in browser. Now, when we try to go back from new-item-1 to previous page, it redirects to /new page which again redirects to new document page /new-item-2 forming a recursive behaviour which never allows user to go back.

Main cause for this is that set_route always push the route internally and there is no support for replacing the existing route.

Changes

• Introduced new route flag called replace_route.
• Automatically reset routes_flags after set_route.
• Used this flag in formview.js to solve mentioned issue.

---

(This issue occurs in Workspace - when there is any Shortcut has New Document View)

To Replicate

In ERPNext Installation...

Step 1: Change Workspace Config (temporary)

• Go to Workspace List > Home

• In Shortcuts section, Change the Document to View to New for Item

  

Step 2: Replicate

• Go to home page and click on Item shortcut (as shown in the above GIFs)
• Click the back button

Step 3: Reset Workspace Config

• Go to Workspace List > Home
• In Shortcut section, Change the Document to View back to unset

[hasnain2808]

@pruthvi145
I am unable to replicate the issue shown in the gif in the latest develop
Can you provide more info on how to replicate?
some snippet or steps would be great

[pruthvi145]

Hi @hasnain2808, I updated the description for replicating this issue. Let me know if you still can not be able to replicate it.

[surajshetty3416]

@Mergifyio backport version-13-hotfix

[mergify]

backport version-13-hotfix

✅ Backports have been created

• #15648 fix: Recursive routing for Form route (backport #15539) has been created for branch version-13-hotfix