Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved validation for py2 compatible #16852

Merged
merged 2 commits into from
May 9, 2022
Merged

fix: improved validation for py2 compatible #16852

merged 2 commits into from
May 9, 2022

Conversation

shadrak98
Copy link
Contributor

  • Used urlparse over urllib to make it compatible with python2

@phot0n
Copy link
Contributor

phot0n commented May 9, 2022

we've dropped py2 support right? 🤔
ref: #10221

@shadrak98
Copy link
Contributor Author

we've dropped py2 support right? 🤔 ref: #10221

This is for version 12

ankush
ankush reviewed May 9, 2022
View reviewed changes
frappe/utils/csvutils.py Outdated Show resolved Hide resolved
ChillarAnand
ChillarAnand previously approved these changes May 9, 2022
View reviewed changes
@gavindsouza gavindsouza merged commit 8481a4d into frappe:version-12-hotfix May 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChillarAnand ChillarAnand ChillarAnand approved these changes

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

@ankush ankush Awaiting requested review from ankush

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shadrak98 @phot0n @ChillarAnand @ankush @gavindsouza