fix: max_positive_value for Integer types #17712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
reviewed
Aug 2, 2022
ankush
added
Skip CI
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* fix: max_positive_value for Integer types * style: formatting Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit d88d9f5)
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* fix: max_positive_value for Integer types * style: formatting Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit d88d9f5)
ankush
pushed a commit
that referenced
this pull request
Aug 2, 2022
ankush
pushed a commit
that referenced
this pull request
Aug 2, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-03) ### Bug Fixes * Append to condition misleading message ([#17696](#17696)) ([#17709](#17709)) ([f05b517](f05b517)) * **global_search:** Trigger rebuilding on Custom Field's property change ([#17706](#17706)) ([a5d576f](a5d576f)) * max_positive_value for Integer types ([#17712](#17712)) ([#17714](#17714)) ([306af63](306af63)) * set /app as redirect for pageview home button ([#17715](#17715)) ([#17717](#17717)) ([594944a](594944a)) * translate each role ([6816f83](6816f83)) * use `throw` ([f7ce174](f7ce174)) * use warn util ([c66fa28](c66fa28)) ### Performance Improvements * reduce DB call in `frappe.client.get` ([#17665](#17665)) ([#17711](#17711)) ([1655fb3](1655fb3)) * specify reference doctype in filters ([#17704](#17704)) ([fc230b4](fc230b4))
developmentforpeople
pushed a commit
to developmentforpeople/frappe
that referenced
this pull request
Aug 7, 2022
## [14.0.1](frappe/frappe@v14.0.0...v14.0.1) (2022-08-03) ### Bug Fixes * Append to condition misleading message ([frappe#17696](frappe#17696)) ([frappe#17709](frappe#17709)) ([f05b517](frappe@f05b517)) * **global_search:** Trigger rebuilding on Custom Field's property change ([frappe#17706](frappe#17706)) ([a5d576f](frappe@a5d576f)) * max_positive_value for Integer types ([frappe#17712](frappe#17712)) ([frappe#17714](frappe#17714)) ([306af63](frappe@306af63)) * set /app as redirect for pageview home button ([frappe#17715](frappe#17715)) ([frappe#17717](frappe#17717)) ([594944a](frappe@594944a)) * translate each role ([6816f83](frappe@6816f83)) * use `throw` ([f7ce174](frappe@f7ce174)) * use warn util ([c66fa28](frappe@c66fa28)) ### Performance Improvements * reduce DB call in `frappe.client.get` ([frappe#17665](frappe#17665)) ([frappe#17711](frappe#17711)) ([1655fb3](frappe@1655fb3)) * specify reference doctype in filters ([frappe#17704](frappe#17704)) ([fc230b4](frappe@fc230b4))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
# [13.37.0](v13.36.3...v13.37.0) (2022-08-09) ### Bug Fixes * allow system managers to toggle email queue ([c004846](c004846)) * allow to import time field ([#17677](#17677)) ([#17690](#17690)) ([59f58c7](59f58c7)) * check permission before sending email ([bb73014](bb73014)) * Dropdown selection list in Reports should be translatable ([#17679](#17679)) ([8c0e5ab](8c0e5ab)) * **global_search:** Trigger rebuilding on Custom Field's property change ([#17705](#17705)) ([b4ff5b2](b4ff5b2)) * max_positive_value for Integer types ([#17712](#17712)) ([#17713](#17713)) ([e173e64](e173e64)) * merge conflict ([2f71fb1](2f71fb1)) * restored patch and remove unused import ([b2232f1](b2232f1)) * return promise ([#17646](#17646)) ([#17666](#17666)) ([d931e26](d931e26)) * Show Report & Dashboard View for File Doctype (backport [#17688](#17688)) ([#17695](#17695)) ([ad09e87](ad09e87)) * version bump regex in automated release ([#17725](#17725)) ([#17726](#17726)) ([a4f682a](a4f682a)) ### Features * Role based permission for Dashboard Chart ([#17634](#17634)) ([#17655](#17655)) ([c3f45e7](c3f45e7)) ### Performance Improvements * reduce DB calls in `frappe.client.get` (and other changes) (backport [#17665](#17665)) ([#17710](#17710)) ([5fe4924](5fe4924)) * reduce DB calls made in `get_fetch_values` ([#17671](#17671)) ([#17738](#17738)) ([fc58a87](fc58a87)) * specify reference doctype in filters ([#17703](#17703)) ([88a59d8](88a59d8))
s-aga-r
added
bug
and removed
backport version-13-hotfix
Skip CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source / Reference: ISS-22-23-01561
The max values for Integer types are:
Before:
Screen.Recording.2022-08-02.at.3.23.25.PM.mov
After:
Screen.Recording.2022-08-02.at.3.38.02.PM.mov