feat: operation level locking for CLI commands #19162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
force-pushed
the
lock_site_specific_actions
branch
from
163eeac
to
92b4022
Compare
ankush
force-pushed
the
lock_site_specific_actions
branch
from
92b4022
to
103cbb9
Compare
This prevents mistakenly issuing same commands twice which can be dangerous. added global lock(s): - [x] bench build added site level lock(s): - [x] bench new-site sitename - [x] bench --site sitename migrate - [x] bench install-app appname - [x] bench build - [x] bench restore (the code is just meh, needs some cleanup) closes frappe#13215
ankush
force-pushed
the
lock_site_specific_actions
branch
from
103cbb9
to
710d603
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19162 +/- ##
===========================================
- Coverage 63.72% 63.69% -0.03%
===========================================
Files 751 751
Lines 67745 67883 +138
Branches 6042 6042
===========================================
+ Hits 43168 43236 +68
- Misses 21147 21217 +70
Partials 3430 3430
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents mistakenly issuing same commands twice which can be dangerous.
added global lock(s):
added site level lock(s):
closes #13215
extends #19133
no-docs