fix(build): use NamedTemporaryFile instead of insecure mktemp function #19387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
|
build is atomic after #19162, security wise I don't think this is an issue as it's just static assets? |
|
I agree with that but despite using it for building assests it is vulnerable as the name maybe hijacked by some user causing some harm to programs and also its deprecated since python 2.3, we can replace it to be on safe side. |
|
@AHasanin agree. Check test failures, doesn't seem to be working as expected. |
ankush
added
tests-failing
github-actions
bot
added
the
add-test-cases
AHasanin
force-pushed
the
fix-insecure-mktemp-function
branch
from
4ef50ab
to
5e6ac70
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mktemp introduces security vulnerabilities because there is no guarantee that the creation and open operations will happen atomically, we can use either NamedTemporaryFile or TemporaryFile from the tempfile module in python.
https://codeql.github.com/codeql-query-help/python/py-insecure-temporary-file/