fix(workflow): Remove docstatus field from get_workflow_state_count (backport #19332) #19344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
shariquerik
and removed request for
a team
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [14.20.0](v14.19.1...v14.20.0) (2022-12-20) ### Bug Fixes * allow zero page length in `get_list` to return complete list ([#19322](#19322)) ([#19341](#19341)) ([715aaa6](715aaa6)) * better check of whether doctype is child table ([#19329](#19329)) ([#19343](#19343)) ([0c0d1ef](0c0d1ef)) * datepicker not working for arabic language (backport [#19358](#19358)) ([#19361](#19361)) ([8d791cc](8d791cc)) * db ssl connection ([#19308](#19308)) ([#19339](#19339)) ([3bf65be](3bf65be)) * dont share with self for standard users (backport [#19327](#19327)) ([#19338](#19338)) ([a3be135](a3be135)) * duplicate unique indexes (backport [#19291](#19291)) ([#19297](#19297)) ([bc92e1c](bc92e1c)) * handle `HTML` code field's `has_content` ([9bc679e](9bc679e)) * if grid custom button is not set grid has some extra space on top ([4f19f68](4f19f68)) * in web form if print format is empty getting error ([f8e227c](f8e227c)) * move filelock import to function ([ee9b1aa](ee9b1aa)) * postgres query ([#19357](#19357)) ([#19359](#19359)) ([12ecae2](12ecae2)) * **postgres:** psql with remote databases (backport [#19362](#19362)) ([#19366](#19366)) ([60c853d](60c853d)) * restore missing `helpful` and `not_helpful` fields to help article doctype. ([#19309](#19309)) ([#19316](#19316)) ([3950865](3950865)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46) * sort prepared report filters ([#19267](#19267)) ([b3e16b8](b3e16b8)) * **trim-database:** Dont act on non-frappe tables (backport [#19292](#19292)) ([#19298](#19298)) ([34b2b24](34b2b24)) * use stricter regex for `sanitize_searchfield` (backport [#19277](#19277)) ([#19303](#19303)) ([4e870b3](4e870b3)) * **workflow:** Remove docstatus field from get_workflow_state_count ([#19332](#19332)) ([#19344](#19344)) ([34e8ecb](34e8ecb)) ### Features * add parameters language and letter_head to `download_pdf` ([99631d2](99631d2)) * fields for attaching (html) meta tags in web form (backport [#19306](#19306)) ([#19307](#19307)) ([6b0e585](6b0e585)) ### Performance Improvements * reuse `_doc_before_save` in `doc.get_latest` (backport [#19326](#19326)) ([#19346](#19346)) ([ff3de82](ff3de82))
|
🎉 This PR is included in version 14.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
developmentforpeople
pushed a commit
to developmentforpeople/frappe
that referenced
this pull request
Jan 3, 2023
…rappe#19332) (frappe#19344) remove docstatus from get_workflow_state_count as it is not being used and causes error with postgresql as it requires the selected column to either appear in the group by clause or an aggregat function (cherry picked from commit 57bc2eb) Co-authored-by: Ahmed Hasanin <52963581+AHasanin@users.noreply.github.com>
developmentforpeople
pushed a commit
to developmentforpeople/frappe
that referenced
this pull request
Jan 3, 2023
# [14.20.0](frappe/frappe@v14.19.1...v14.20.0) (2022-12-20) ### Bug Fixes * allow zero page length in `get_list` to return complete list ([frappe#19322](frappe#19322)) ([frappe#19341](frappe#19341)) ([715aaa6](frappe@715aaa6)) * better check of whether doctype is child table ([frappe#19329](frappe#19329)) ([frappe#19343](frappe#19343)) ([0c0d1ef](frappe@0c0d1ef)) * datepicker not working for arabic language (backport [frappe#19358](frappe#19358)) ([frappe#19361](frappe#19361)) ([8d791cc](frappe@8d791cc)) * db ssl connection ([frappe#19308](frappe#19308)) ([frappe#19339](frappe#19339)) ([3bf65be](frappe@3bf65be)) * dont share with self for standard users (backport [frappe#19327](frappe#19327)) ([frappe#19338](frappe#19338)) ([a3be135](frappe@a3be135)) * duplicate unique indexes (backport [frappe#19291](frappe#19291)) ([frappe#19297](frappe#19297)) ([bc92e1c](frappe@bc92e1c)) * handle `HTML` code field's `has_content` ([9bc679e](frappe@9bc679e)) * if grid custom button is not set grid has some extra space on top ([4f19f68](frappe@4f19f68)) * in web form if print format is empty getting error ([f8e227c](frappe@f8e227c)) * move filelock import to function ([ee9b1aa](frappe@ee9b1aa)) * postgres query ([frappe#19357](frappe#19357)) ([frappe#19359](frappe#19359)) ([12ecae2](frappe@12ecae2)) * **postgres:** psql with remote databases (backport [frappe#19362](frappe#19362)) ([frappe#19366](frappe#19366)) ([60c853d](frappe@60c853d)) * restore missing `helpful` and `not_helpful` fields to help article doctype. ([frappe#19309](frappe#19309)) ([frappe#19316](frappe#19316)) ([3950865](frappe@3950865)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46) * sort prepared report filters ([frappe#19267](frappe#19267)) ([b3e16b8](frappe@b3e16b8)) * **trim-database:** Dont act on non-frappe tables (backport [frappe#19292](frappe#19292)) ([frappe#19298](frappe#19298)) ([34b2b24](frappe@34b2b24)) * use stricter regex for `sanitize_searchfield` (backport [frappe#19277](frappe#19277)) ([frappe#19303](frappe#19303)) ([4e870b3](frappe@4e870b3)) * **workflow:** Remove docstatus field from get_workflow_state_count ([frappe#19332](frappe#19332)) ([frappe#19344](frappe#19344)) ([34e8ecb](frappe@34e8ecb)) ### Features * add parameters language and letter_head to `download_pdf` ([99631d2](frappe@99631d2)) * fields for attaching (html) meta tags in web form (backport [frappe#19306](frappe#19306)) ([frappe#19307](frappe#19307)) ([6b0e585](frappe@6b0e585)) ### Performance Improvements * reuse `_doc_before_save` in `doc.get_latest` (backport [frappe#19326](frappe#19326)) ([frappe#19346](frappe#19346)) ([ff3de82](frappe@ff3de82))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19332 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com