Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite query for postgres #20557

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: rewrite query for postgres #20557

merged 1 commit into from
Apr 3, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 3, 2023

No description provided.

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Apr 3, 2023
@ankush ankush added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed add-test-cases Add test case to validate fix or enhancement labels Apr 3, 2023
@ankush ankush marked this pull request as ready for review April 3, 2023 08:28
@ankush ankush requested review from a team and shariquerik and removed request for a team April 3, 2023 08:28
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #20557 (bce25b7) into develop (5fff669) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20557      +/-   ##
===========================================
+ Coverage    63.80%   63.83%   +0.02%     
===========================================
  Files          758      758              
  Lines        68699    68702       +3     
  Branches      6198     6198              
===========================================
+ Hits         43836    43858      +22     
+ Misses       21328    21309      -19     
  Partials      3535     3535              
Flag Coverage Δ
server 68.82% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit fa32b61 into develop Apr 3, 2023
@ankush ankush deleted the pg_address_query branch April 3, 2023 09:17
mergify bot pushed a commit that referenced this pull request Apr 3, 2023
mergify bot pushed a commit that referenced this pull request Apr 3, 2023
ankush added a commit that referenced this pull request Apr 3, 2023
(cherry picked from commit fa32b61)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Apr 3, 2023
(cherry picked from commit fa32b61)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Apr 4, 2023
# [14.31.0](v14.30.0...v14.31.0) (2023-04-04)

### Bug Fixes

* allow `reset_otp_secret` only if Two Factor Auth is enabled ([#20506](#20506)) ([#20561](#20561)) ([ca486c4](ca486c4))
* allowed only POST and PUT methods in `rename_doc` ([#20504](#20504)) ([#20565](#20565)) ([fd1f6fe](fd1f6fe))
* bulk update using doc method, check perms ([#20522](#20522)) ([2237968](2237968))
* cannot restore cancelled document if workflow is active ([547efe3](547efe3))
* Check if reference_name is set ([2e9068b](2e9068b))
* content_type can be `None` during file upload ([#20572](#20572)) ([#20574](#20574)) ([ebc6059](ebc6059))
* date field shouldn't be formatted for TZ ([#20486](#20486)) ([#20490](#20490)) ([07b7b46](07b7b46))
* don't hide tab with dashboard if there is a visible section/control ([084e8af](084e8af))
* Drop message_id index before migrating email queue ([#20376](#20376)) ([#20578](#20578)) ([394c232](394c232))
* email linking and message_id indexing ([#20356](#20356)) ([#20579](#20579)) ([5ae94ef](5ae94ef))
* escape HTML instead of sanitizing ([2269d6e](2269d6e))
* fix address query for postgres ([f01566a](f01566a)), closes [/github.com//pull/20537#ref-pullrequest-1645575433](https://github.com//github.com/frappe/frappe/pull/20537/issues/ref-pullrequest-1645575433)
* get workflow_state_fieldname instead of setting workflow_state to none ([bac4e9b](bac4e9b))
* Handle JsBarcode exceptions ([#20532](#20532)) ([b1c3d8b](b1c3d8b))
* heatmap not reset on dashboard refresh ([3c0659b](3c0659b))
* hide chart and heatmap on dashboard reset ([cec7a73](cec7a73))
* Incorrect use of the Walrus operator ([a70a5ca](a70a5ca))
* nestedset rename ([#20498](#20498)) ([#20499](#20499)) ([b831392](b831392))
* removed unnecessary usage of `[@frappe](https://github.com/frappe).whitelist` ([#20503](#20503)) ([#20563](#20563)) ([0af8315](0af8315))
* rewrite query for postgres ([#20557](#20557)) ([#20559](#20559)) ([d754be5](d754be5))
* sending mails to unintended recipients as cc ([1c47643](1c47643))
* **UI:** align link cards & charts on workspace ([82cfd33](82cfd33))
* unsubscribe from list_update before resubbing ([#20450](#20450)) ([#20581](#20581)) ([7866605](7866605))
* use chart type passed to `render_graph` on form dashboards ([015f7db](015f7db))

### Features

* Disable Sharing globally (backport [#20318](#20318)) ([#20492](#20492)) ([67a537c](67a537c))
* list-view click and drag on check box to select multiple rows (backport [#20457](#20457)) ([#20568](#20568)) ([f757a37](f757a37))
* make workflow state translatable ([#20412](#20412)) ([8675789](8675789))
* **util:** `get_table_name`: wrap in backticks ([#20553](#20553)) ([#20556](#20556)) ([5c56dff](5c56dff))

### Performance Improvements

* Faster address query with explicit joins (backport [#20537](#20537)) ([#20540](#20540)) ([2ef7ef5](2ef7ef5))
* unsubscribe from list_update events ([#20423](#20423)) ([#20580](#20580)) ([8a63144](8a63144))
frappe-pr-bot pushed a commit that referenced this pull request Apr 4, 2023
# [13.52.0](v13.51.3...v13.52.0) (2023-04-04)

### Bug Fixes

* better error logging while sending email ([#20570](#20570)) ([8ae4d55](8ae4d55))
* cannot restore cancelled document if workflow is active ([6206dc0](6206dc0))
* escape HTML instead of sanitizing ([68ad9cf](68ad9cf))
* fix address query for postgres ([616dd8b](616dd8b)), closes [/github.com//pull/20537#ref-pullrequest-1645575433](https://github.com//github.com/frappe/frappe/pull/20537/issues/ref-pullrequest-1645575433)
* get workflow_state_fieldname instead of setting workflow_state to none ([3249aa2](3249aa2))
* removed unnecessary usage of `[@frappe](https://github.com/frappe).whitelist` ([#20503](#20503)) ([#20562](#20562)) ([08398cb](08398cb))
* rewrite query for postgres ([#20557](#20557)) ([#20558](#20558)) ([e400c5f](e400c5f))

### Features

* Disable Sharing globally ([#20318](#20318)) [backport] ([#20500](#20500)) ([758873c](758873c))
* make workflow state translatable ([#20412](#20412)) ([#20501](#20501)) ([1545fbd](1545fbd))

### Performance Improvements

* Faster address query with explicit joins (backport [#20537](#20537)) ([#20539](#20539)) ([955a723](955a723))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant