fix: pass reference_doctype to search query methods #20842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isssue: If you create user permissions with "applicable_for" it's supposed to apply those UP to queries when link field is getting queries, however, the reference doctype isn't passed at all to custom queries so there's no way for them to know where it's being linked.
refer:
frappe/frappe/model/db_query.py
Lines 174 to 176 in e6279e0
frappe/frappe/model/db_query.py
Lines 962 to 969 in e6279e0
Fix: pass reference_doctype to queries.
frappe.call
ensures that it's only passed to functions which can accept it, so nothing to worry about ~ backward compatible change.dependent PR: frappe/erpnext#35038
ref: ISS-23-24-00271