Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no API call required to set cookie in browser #21763

Merged

Conversation

sagarvora
Copy link
Contributor

No description provided.

@sagarvora sagarvora requested review from a team and phot0n and removed request for a team July 22, 2023 12:25
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jul 22, 2023
@sagarvora sagarvora removed the add-test-cases Add test case to validate fix or enhancement label Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #21763 (d2becc7) into develop (95167a1) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21763      +/-   ##
===========================================
+ Coverage    63.94%   63.96%   +0.02%     
===========================================
  Files          763      763              
  Lines        69492    69549      +57     
  Branches      6282     6282              
===========================================
+ Hits         44434    44485      +51     
- Misses       21463    21494      +31     
+ Partials      3595     3570      -25     
Flag Coverage Δ
server-ui 29.82% <ø> (+0.01%) ⬆️
ui-tests 51.76% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify mergify bot merged commit a86125a into frappe:develop Jul 22, 2023
23 checks passed
@sagarvora sagarvora deleted the fix-preferred-language-setter branch July 23, 2023 15:29
sagarvora added a commit that referenced this pull request Jul 24, 2023
…-21763

fix: no API call required to set cookie in browser (backport #21763)
sagarvora added a commit that referenced this pull request Jul 24, 2023
…-21763

fix: no API call required to set cookie in browser (backport #21763)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants