fix: fallback to unscrubbed table fieldname if label not found #21826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jll-02
requested review from
a team and
shariquerik
and removed request for
a team
ankush
requested changes
Jul 27, 2023
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
ankush
approved these changes
Jul 27, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
## [13.58.4](v13.58.3...v13.58.4) (2023-08-01) ### Bug Fixes * fallback to unscrubbed table fieldname if label not found ([#21826](#21826)) ([a8091bb](a8091bb)) * removed the output field from the console log ([#21600](#21600)) ([#21854](#21854)) ([1995035](1995035)) ### Performance Improvements * dont reload doc when already saving ([#21869](#21869)) ([#21876](#21876)) ([706892d](706892d))
|
🎉 This PR is included in version 13.58.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was solved in PR #17599 and the backport to 13 was asked for in #21571
Before
There was a problem with missing mandatory fields in a child table without a label. The error thrown looked something like this:
After
The correct error message will be thrown:
