perf: dont reload doc when already saving

[sagarvora]

Issue

Document gets reloaded in the following code even though it's already saving:

frappe/frappe/public/js/frappe/model/model.js

Lines 152 to 154 in 8418858

	if (data.modified !== cur_frm.doc.modified) {
	if (!cur_frm.is_dirty()) {
	cur_frm.reload_doc();

Underlying problem is in following sequence:

• first the realtime update is received on commit
• then the save response is received

The problematic code was introduced in #20126 to ensure that workflows work as expected. But frappe.ui.form.is_saving should be false during that so it should still work as expected.

Additionally, the above code causes refresh event to get triggered twice:

• once after save
• once inside reload_doc

That leads to issues like this:

Solution

Don't trigger reload if form is already saving.

[codecov]

Codecov Report

Merging #21869 (f8b4cd1) into develop (8418858) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21869   +/-   ##
========================================
  Coverage    61.82%   61.83%           
========================================
  Files          765      765           
  Lines        72975    72974    -1     
  Branches      6291     6290    -1     
========================================
+ Hits         45120    45123    +3     
+ Misses       24278    24275    -3     
+ Partials      3577     3576    -1     

Flag	Coverage Δ
server-ui	28.12% <ø> (ø)
ui-tests	51.71% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.