Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only rate limit if frappe.request is set #21928

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

sagarvora
Copy link
Contributor

No description provided.

@sagarvora sagarvora requested review from a team and maharshivpatel and removed request for a team August 5, 2023 07:24
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Aug 5, 2023
@sagarvora sagarvora removed the add-test-cases Add test case to validate fix or enhancement label Aug 5, 2023
ankush
ankush previously requested changes Aug 5, 2023
frappe/rate_limiter.py Outdated Show resolved Hide resolved
@sagarvora sagarvora requested a review from ankush August 5, 2023 07:33
@sagarvora
Copy link
Contributor Author

tests passing locally ✅

image

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #21928 (7aed89a) into develop (8817c22) will increase coverage by 0.00%.
Report is 6 commits behind head on develop.
The diff coverage is 65.38%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21928   +/-   ##
========================================
  Coverage    61.87%   61.87%           
========================================
  Files          765      765           
  Lines        72999    73000    +1     
  Branches      6292     6292           
========================================
+ Hits         45171    45172    +1     
  Misses       24264    24264           
  Partials      3564     3564           
Flag Coverage Δ
server 65.21% <65.38%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sagarvora sagarvora merged commit e588f2d into frappe:develop Aug 5, 2023
18 of 19 checks passed
@sagarvora sagarvora deleted the fix-rate-limiter branch August 5, 2023 17:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants