fix: validate fieldname in get_group_by_count (backport #21932) #21942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: validate fieldname in get_group_by_count * test: call get_group_by_count with invalid field * test: is_default_field (cherry picked from commit 5fce1a5) # Conflicts: # frappe/desk/listview.py # frappe/tests/test_listview.py # frappe/tests/test_model_utils.py
mergify
bot
requested review from
maharshivpatel
and removed request for
a team
ankush
force-pushed
the
mergify/bp/version-13-hotfix/pr-21932
branch
from
46af94b
to
efe3514
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
## [13.58.5](v13.58.4...v13.58.5) (2023-08-09) ### Bug Fixes * center notes text in FileUploader ([#21901](#21901)) ([19e1811](19e1811)) * check before deleting prepared report ([#21950](#21950)) ([#21951](#21951)) ([bc9a901](bc9a901)) * debounce form refresh from realtime events ([#21905](#21905)) ([#21906](#21906)) ([b81153f](b81153f)) * disable activity log global search ([5d9d04a](5d9d04a)) * only allow system manager to start backups ([d51e13a](d51e13a)) * **print:** Added properties page-width, page-height ([a966031](a966031)) * validate fieldname in get_group_by_count (backport [#21932](#21932)) ([#21942](#21942)) ([dabbb73](dabbb73)) * validate type in share.get_users ([#21931](#21931)) ([#21933](#21933)) ([1270e63](1270e63)) ### Performance Improvements * **customize_form:** rebuild global search in bg ([4725505](4725505)) * lower limit for global search ([8ff3353](8ff3353))
|
🎉 This PR is included in version 13.58.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21932 done by Mergify.
Cherry-pick of 5fce1a5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com