Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fair-er scheduling for multitenant deploys #22022

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 12, 2023

By default, the scheduler loop gets sites and works on one site at a time. Sites that come first alphabetically automatically get higher priority.

This PR just randomizes the behaviour so scheduling priorities are random and fair according to prng gods.

@ankush ankush requested review from a team and surajshetty3416 and removed request for a team August 12, 2023 05:24
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Aug 12, 2023
@ankush ankush added the Skip CI Doesn't run Ci for this PR. label Aug 12, 2023
@ankush ankush merged commit 19d33a9 into frappe:develop Aug 12, 2023
12 of 18 checks passed
@ankush ankush deleted the fair_scheduling branch August 12, 2023 05:25
@ankush ankush added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed add-test-cases Add test case to validate fix or enhancement labels Aug 12, 2023
mergify bot pushed a commit that referenced this pull request Aug 12, 2023
mergify bot pushed a commit that referenced this pull request Aug 12, 2023
ankush added a commit that referenced this pull request Aug 12, 2023
(cherry picked from commit 19d33a9)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Aug 12, 2023
(cherry picked from commit 19d33a9)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Aug 15, 2023
# [14.45.0](v14.44.0...v14.45.0) (2023-08-15)

### Bug Fixes

* block format attributes ([#22028](#22028)) ([#22030](#22030)) ([d804c00](d804c00))
* check permission on autorepeat ([5103b4e](5103b4e))
* configurable rename job queue ([#21996](#21996)) ([#22001](#22001)) ([2a23bc9](2a23bc9))
* **Contact:** use existing full name ([296d6e9](296d6e9))
* Dashboard shortcuts - Tree view missing ([#22008](#22008)) ([#22009](#22009)) ([277babc](277babc))
* Don't show online/offline alerts when tab not active ([#22039](#22039)) ([#22040](#22040)) ([1fedaa4](1fedaa4))
* fair-er scheduling for multitenant deploys ([#22022](#22022)) ([#22024](#22024)) ([3880f0c](3880f0c))
* multiple input element's in a single control ([#22020](#22020)) ([22f7fd8](22f7fd8))
* sanitize frappe._dicts too in TB sanitizer ([#22012](#22012)) ([#22013](#22013)) ([95cb883](95cb883))
* Support dynamic filter for Reports w/o js config ([1b10c42](1b10c42))
* tree report has 2 total rows while printing it ([0d2caeb](0d2caeb))
* validate email template subject and minor refactor ([#19102](#19102)) ([#21976](#21976)) ([a7db78b](a7db78b))
* **Web Form:** translation of forwarding message (backport [#21948](#21948)) ([#21959](#21959)) ([6f9dbce](6f9dbce))

### Features

* **contact template:** clickable email ids and phone numbers, less labels ([#20247](#20247)) ([#21998](#21998)) ([71dfb0a](71dfb0a))
frappe-pr-bot pushed a commit that referenced this pull request Aug 15, 2023
## [13.58.6](v13.58.5...v13.58.6) (2023-08-15)

### Bug Fixes

* block format attributes ([#22028](#22028)) ([#22029](#22029)) ([d146982](d146982))
* check permission on autorepeat ([7dd6b6d](7dd6b6d))
* fair-er scheduling for multitenant deploys ([#22022](#22022)) ([#22023](#22023)) ([dc363bb](dc363bb))
* ignore_user_type can be applied by System User ([#21990](#21990)) ([#22036](#22036)) ([21bc796](21bc796))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 Skip CI Doesn't run Ci for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant